Removed deprecated usages of the option summarizeProtocolTree #23355
+10
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: loader
pragya91
force-pushed
the
praggarg/fix-imports
branch
from
6674943 to
7332a96
Compare
jason-ha
reviewed
Dec 23, 2024
There was a problem hiding this comment.
- Looks like
@fluidframework/container-loader's version ofILoaderOptionsshould be removed as well. - Recommend review of
summarizeProtocolTreehits in code base as well to confirm there are no dangling oddities. - This will need to wait until 2.30 to happen as the related issue was not in the 2.20 break list. I updated issue to be in the 2.30 list.
- Create a branch under main repo under
test/legacy-breaks/client/2.30/according to legacy break process. - Update the legacy break issue to be associated with replacement PR (test/ branch based) and assuming also removing extra ILoaderOptions per (1), then update issue title and content (recommend following Breaking Change template for content).
| @@ -28,6 +28,7 @@ import { | |||
| isFluidCodeDetails, | |||
| IDeltaManager, | |||
| ReadOnlyInfo, | |||
| ILoaderOptions, | |||
There was a problem hiding this comment.
Should update to a type only import while touching and respect more alphabetizing (most entries are sorted; just the last few are not)
Comment on lines
127
to
128
| // eslint-disable-next-line import/no-deprecated | ||
| import { IDetachedBlobStorage, ILoaderOptions, RelativeLoader } from "./loader.js"; | ||
| import { IDetachedBlobStorage, RelativeLoader } from "./loader.js"; |
There was a problem hiding this comment.
Can you please reformat so that the lint disable applies per import rather than for all imports? Thanks!
pragya91
force-pushed
the
praggarg/fix-imports
branch
from
7332a96 to
73a5b97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing deprecated code that usage of
summarizeProtocolTreeoption from the code. The change is non-breaking in nature. The PR only removes the old unused usages of summarizeProtocolTree.