Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some small improvements to docs and tools around running tests locally against real services #23387

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

markfields
Copy link
Member

Description

  • Update getkeys instructions based on additional required step in the prompt flow
  • Add inputs for providing secrets when running e2e tests against real services

@github-actions github-actions bot added the base: main PRs targeted against main branch label Dec 20, 2024
Copy link
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  170138 links
    1596 destination URLs
    1825 URLs ignored
       0 warnings
       0 errors


@@ -146,7 +148,8 @@
"fluid__test__driver": "r11s",
"fluid__test__backCompat": "${input:backCompat}",
"fluid__test__r11sEndpointName": "${input:r11sEndpoint}",
"FLUID_TEST_VERBOSE": "${input:verboseConsoleOutputt}",
"FLUID_TEST_VERBOSE": "${input:verboseConsoleOutput}",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abe27342 I guess this will block the fallthrough to the local environment variables, so probably shouldn't merge this as-is. Any ideas on how to organize/implement this to make it quick/easy to plug them in on CodeSpaces or another place where getkeys hasn't been run on the local machine?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant