-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove line rate comparison for code coverage as that is not much useful due to comments #23389
Conversation
…ful due to comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bit looks fine. I suggest that we either remove the properties related to line coverage from CodeCoverageComparison
or add notes to them saying we deliberately don't use them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is coverage reported for type only files with this change? They have 1 branch that is never covered? That happens all the time or some?
Definitely forward progress - just wondering what to expect.
Removed line coverage in order to prevent that. From what I noticed, the types or declaration will not be counted a branch and therefore, that would not affect the code coverage. We will plan to add method coverage as well alongside branch coverage to make it more robust. |
Description
AB#23400
Based on the feedback and analysis we are removing line rate comparison for code coverage as that is not much useful due to comments increasing and decreasing it based on whether the comments was in covered code or non-covered code.