docs: update/correct comments for submitSignalFn #23403
Open
+20
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
including notes about how change might be possible (removing `@alpha` is insufficient)
jason-ha
requested review from
Copilot,
alexvy86,
ChumpChief and
WillieHabi
and removed request for
Copilot
github-actions
bot
added
area: loader
ChumpChief
reviewed
Dec 31, 2024
| * {@link @fluidframework/core-interfaces#ISignalEnvelope}. | ||
| * See {@link https://dev.azure.com/fluidframework/internal/_workitems/edit/7462}. | ||
| * | ||
| * To get `IContainerContext` internal, likely externally exposed uses will need |
There was a problem hiding this comment.
I don't think we're on a track to make IContainerContext internal, but rather I think an equivalent eventually may become part of the public API. This is (currently) required for the extensibility point of a customer-defined IRuntimeFactory, which is actually a useful tool. The interfaces could do with a lot of improvements, but the core concept seems valuable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
including notes about how change might be possible (removing
@alphais insufficient)