MergeTree: Remove Partial IRemovalInfo and IMoveInfo from Segments #23406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
There was a problem hiding this comment.
Copilot reviewed 5 out of 15 changed files in this pull request and generated no comments.
Files not reviewed (10)
- packages/dds/merge-tree/src/test/client.applyMsg.spec.ts: Evaluated as low risk
- packages/dds/merge-tree/src/test/index.ts: Evaluated as low risk
- packages/dds/merge-tree/src/test/testClient.ts: Evaluated as low risk
- packages/dds/merge-tree/src/test/reconnectHelper.ts: Evaluated as low risk
- packages/dds/merge-tree/src/test/mergeTree.markRangeRemoved.spec.ts: Evaluated as low risk
- packages/dds/merge-tree/src/snapshotV1.ts: Evaluated as low risk
- packages/dds/merge-tree/src/segmentInfos.ts: Evaluated as low risk
- packages/dds/merge-tree/src/snapshotlegacy.ts: Evaluated as low risk
- packages/dds/merge-tree/api-report/merge-tree.legacy.alpha.api.md: Evaluated as low risk
- packages/dds/merge-tree/src/partialLengths.ts: Evaluated as low risk
anthony-murphy
force-pushed
the
info-only
branch
from
e1f0e80 to
a5b6b79
Compare
|
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output |
anthony-murphy
commented
Dec 27, 2024
| if (markerId) { | ||
| this.idToMarker.set(markerId, newSegment); | ||
| } | ||
| for (const newSegment of newSegments |
There was a problem hiding this comment.
i recommend turning off whitespace diff, as this change is small, but removed a layer of nesting so lot of whitespace churn.
jzaffiro
approved these changes
Jan 2, 2025
| @@ -706,7 +709,10 @@ export class PartialSequenceLengths { | |||
|
|
|||
| const hasOverlap = moveInfo.movedClientIds.length > 1; | |||
| moveClientOverlap = hasOverlap ? moveInfo.movedClientIds : undefined; | |||
| } else if (segment.wasMovedOnInsert) { | |||
| } // BUG BUG: something fishy here around how/when move info is passed or not | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is further refactoring which will aid in the eventual removal of the deprecated properties from ISegment. This change removed the partial implementation of IRemovalInfo and IMoveInfo from ISegmentPrivate which forces consistent access to those infos via the typeguards and helpers for the associated infos. This consistent access also ensures strong typing, and correct handling for optional vs required properties.