refactor: Update cross-spawn transitive dependency across the repo #23415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: build
There was a problem hiding this comment.
Copilot reviewed 5 out of 14 changed files in this pull request and generated no comments.
Files not reviewed (9)
- build-tools/packages/build-infrastructure/src/test/data/testRepo/package.json: Language not supported
- build-tools/pnpm-lock.yaml: Evaluated as low risk
- common/build/eslint-config-fluid/pnpm-lock.yaml: Evaluated as low risk
- tools/test-tools/pnpm-lock.yaml: Evaluated as low risk
- tools/getkeys/pnpm-lock.yaml: Evaluated as low risk
- build-tools/packages/build-infrastructure/src/test/data/testRepo/pnpm-lock.yaml: Evaluated as low risk
- common/build/eslint-plugin-fluid/pnpm-lock.yaml: Evaluated as low risk
- server/historian/pnpm-lock.yaml: Evaluated as low risk
- server/gitrest/pnpm-lock.yaml: Evaluated as low risk
alexvy86
commented
Dec 31, 2024
| @@ -15,6 +15,6 @@ | |||
| "@fluid-tools/build-infrastructure": "link:../../../../../build-infrastructure" | |||
| }, | |||
| "devDependencies": { | |||
| "@changesets/cli": "^2.27.9" | |||
| "@changesets/cli": "^2.27.11" | |||
There was a problem hiding this comment.
Test pnpm workspace for some build-tools tests. cross-spawn is a transitive dependency through this.
krauders
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the cross-spawn dependency across the repo (including a test pnpm workspace inside build-tools) to address https://nvd.nist.gov/vuln/detail/CVE-2024-21538.
In a few packages, some other transitive dependencies got updated even when targeting just cross-spawn, but the changes seem ok.
Reviewer Guidance
The review process is outlined on this wiki page.
Note: there are still a few instances of cross-spawn in major versions other than 7 due to dependencies that can't be addressed quickly + easily.