Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(devtools): Move and rename devtools-example #23417

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

alexvy86
Copy link
Contributor

@alexvy86 alexvy86 commented Dec 31, 2024

Description

Renames devtools-example to devtools-test-app, moves it from the @fluid-example scope to @fluid-private, and moves it to a folder with the new name. Pure renames, no changes to functionality.

Reviewer Guidance

The review process is outlined on this wiki page.

AB#7436

@Copilot Copilot bot review requested due to automatic review settings December 31, 2024 19:23
@alexvy86 alexvy86 requested a review from a team as a code owner December 31, 2024 19:23

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 28 out of 29 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • packages/tools/devtools/devtools-test-app/package.json: Language not supported
@github-actions github-actions bot added dependencies Pull requests that update a dependency file base: main PRs targeted against main branch labels Dec 31, 2024
Copy link
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  170486 links
    1603 destination URLs
    1838 URLs ignored
       0 warnings
       0 errors


@alexvy86 alexvy86 merged commit 30491c2 into microsoft:main Jan 3, 2025
34 checks passed
@alexvy86 alexvy86 deleted the make-devtools-test-app-private branch January 3, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base: main PRs targeted against main branch dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants