refactor: Inline yaml templates and fix bug #23418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- tools/pipelines/templates/download-api-extractor-artifact.yml: Language not supported
- tools/pipelines/templates/upload-json-steps.yml: Language not supported
Comments suppressed due to low confidence (1)
tools/pipelines/publish-api-model-artifact.yml:134
- [nitpick] The variable name 'isLatestMinorOfMajorTrain' should be verified to ensure it accurately reflects its purpose in the context.
isLatestMinorOfMajorTrain: $[ dependencies.check_branch_version.outputs['SetShouldDeploy.shouldDeploy'] ]
alexvy86
commented
Dec 31, 2024
Comment on lines
-65
to
-66
| - name: isMain | ||
| value: ${{ eq(variables['Build.SourceBranchName'], 'main') }} |
There was a problem hiding this comment.
Inlined below. Single use, and it's pretty self-explanatory.
alexvy86
commented
Dec 31, 2024
Comment on lines
+143
to
+149
| - task: Bash@3 | ||
| displayName: 'Print computed variables' | ||
| inputs: | ||
| targetType: 'inline' | ||
| script: | | ||
| echo "isLatestMinorOfMajorTrain: $(isLatestMinorOfMajorTrain)" | ||
| echo "majorVersion: $(majorVersion)" |
There was a problem hiding this comment.
Added this new bit for troubleshooting
sonalideshpandemsft
approved these changes
Jan 2, 2025
| archiveFile: '$(Pipeline.Workspace)/$(Build.SourceVersion).tar.gz' | ||
| replaceExistingArchive: true | ||
| verbose: true # Optional | ||
| #quiet: # Optional |
There was a problem hiding this comment.
nit: quiet can be removed?
There was a problem hiding this comment.
It could, I kept it just to keep the changes to the minimum necessary to simplify review. I'll merge like this for now.
|
@microsoft-github-policy-service rerun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
upload-json-steps.ymlanddownload-api-extractor-artifact.ymltemplates were not really that reusable so this PR inlines them into the single pipeline that uses them.It also fixes a bug that caused the JSON artifacts to never be published as
latest-v<major>.tar.gzbecause we were trying to use a variable that only exists at runtime (dependencies.check_branch_version.outputs['SetShouldDeploy.shouldDeploy']) in a "compile-time" condition inupload-json-steps.yml. The condition was thus never true, and the step under it was never present in the pipeline. So I replaced a couple of compile-time conditionals withcondition:nodes in the corresponding tasks, which should make the tasks always appear in the pipeline, but get skipped unless the specified conditions are true.Reviewer Guidance
The review process is outlined on this wiki page.
AB#6846