Merge pull request #5478 from microsoft/Dev

Release 1.24.1127.1
microsoft · Nov 27, 2024 · d16e3e1 · d16e3e1
2 parents 120f8f1 + bc20e30
commit d16e3e1
Show file tree

Hide file tree

Showing 203 changed files with 3,823 additions and 999 deletions.
diff --git a/.github/workflows/CodeCoverage.yml b/.github/workflows/CodeCoverage.yml
@@ -17,10 +17,10 @@ jobs:
       - name: Install Modules
         shell: pwsh
         run: |
-          Install-Module ReverseDSC -Force -Scope AllUsers
-          Install-Module DSCParser -Force -Scope AllUsers
-          Install-Module PSDesiredStateConfiguration -Force -Scope AllUsers
-          Install-Module Pester -Force -SkipPublisherCheck -Scope AllUsers
+          Install-PSResource -Name ReverseDSC -Scope AllUsers -TrustRepository
+          Install-PSResource -Name DSCParser -Scope AllUsers -TrustRepository
+          Install-PSResource -Name PSDesiredStateConfiguration -Scope AllUsers -TrustRepository
+          Install-PSResource -Name Pester -Scope AllUsers -TrustRepository
           [System.Environment]::SetEnvironmentVariable('M365DSCTelemetryEnabled', $false, [System.EnvironmentVariableTarget]::Machine);
       - name: Run Quality Checks
         shell: pwsh

diff --git a/.github/workflows/Unit Tests.yml b/.github/workflows/Unit Tests.yml
@@ -21,10 +21,10 @@ jobs:
       - name: Install Modules
         shell: pwsh
         run: |
-          Install-Module ReverseDSC -Force -Scope AllUsers
-          Install-Module DSCParser -Force -Scope AllUsers
-          Install-Module PSDesiredStateConfiguration -Force -Scope AllUsers
-          Install-Module Pester -Force -SkipPublisherCheck -Scope AllUsers
+          Install-PSResource -Name ReverseDSC -Scope AllUsers -TrustRepository
+          Install-PSResource -Name DSCParser -Scope AllUsers -TrustRepository
+          Install-PSResource -Name PSDesiredStateConfiguration -Scope AllUsers -TrustRepository
+          Install-PSResource -Name Pester -Scope AllUsers -TrustRepository
           [System.Environment]::SetEnvironmentVariable('M365DSCTelemetryEnabled', $false, [System.EnvironmentVariableTarget]::Machine);
       - name: Run Quality Checks
         shell: pwsh

diff --git a/.vscode/GetTestCoverage.ps1 b/.vscode/GetTestCoverage.ps1
@@ -10,7 +10,7 @@ $minVersion = '5.5.0'
 
 $module = Get-Module -ListAvailable | Where-Object { $_.Name -eq $moduleName -and $_.Version -ge $minVersion }
 
-if ($module -ne $null)
+if ($null -ne $module)
 {
     Write-Output "Module $moduleName with version greater than or equal to $minVersion found."
 }

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,61 @@
 # Change log for Microsoft365DSC
 
+# 1.24.1127.1
+
+* AAD
+  * Added ApplicationSecret auth method to multiple resources
+* AADFilteringPolicyRule
+  * Fixed an issue with the export of the Destinations property where
+    the CIMInstance array object was malformed.
+* EXOEOPProtectionPolicyRule
+  * Added support for AccessTokens.
+* EXOExternalInOutlook
+  * Added support for AccessTokens.
+* EXOMailContact
+  * Changed how empty arrays are returned.
+* EXOPlace
+  * Changed how empty arrays are returned.
+* EXORecipientPermission
+  * Added logic to update an existing recipients permissions.
+* EXOTransportRule
+  * Changed how empty arrays are returned.
+* INTUNE
+  * Add parameter `-All` to Graph requests to fetch all policies on Get.
+* IntuneAndroidManagedStoreAppConfiguration
+  * Initial release.
+* IntuneAppConfigurationPolicy
+  * Fixes an issue where assignment was not properly set if the
+    groupId was null.
+    FIXES [#5430](https://github.com/microsoft/Microsoft365DSC/issues/5430)
+* IntuneMobileAppConfigurationPolicyIOS
+  * Removing resource. Already possible with IntuneAppConfigurationDevicePolicy
+* IntuneMobileThreatDefenseConnector
+  * Fixes a NotFound error when the resource does not exist and remove
+    `LastHeartbeatDateTime` from comparison.
+* IntuneRoleAssignment
+  * Improve verbose output and fix copy-pasted variables.
+* IntuneRoleScopeTag
+  * Initial release.
+* TeamsUserPolicyAssignment
+  * Added support for the Global policies.
+* TeamsUpgradePolicy
+  * DEPRECATED: Users properties. Use the TeamsUserPolicyAssignment resource
+    instead.
+* M365DSCUtil
+  * Add default Ensure value `Present` if not specified.
+    FIXES [#5085](https://github.com/microsoft/Microsoft365DSC/issues/5085)
+  * When exporting generate the instance names of resources with their mandatory
+    keys instead of random GUIDs , this makes exports idempotent again
+    FIXES [#5469](https://github.com/microsoft/Microsoft365DSC/issues/5469)
+* MISC
+  * Removed hardcoded Graph urls and replaced by MSCloudLoginAssistant values.
+  * Add separate module handling for PowerShell Core.
+* DEPENDENCIES
+  * Updated DSCParser to version 2.0.0.14.
+  * Updated Microsoft.Graph to version 2.25.0.
+  * Updated Microsoft.PowerApps.Administration.PowerShell to version 2.0.200.
+  * Updated MicrosoftTeams to version 6.7.0.
+
 # 1.24.1120.1
 
 * AADAdminConsentRequestPolicy
@@ -50,7 +106,7 @@
 * AADRoleEligibilityScheduleRequest
   * Adds support for custom role assignments at app scope.
 * AADRoleSettings
-  * Fixing issue where the ActivateApprover parameter isn't processed correctly
+  * Fixing issue where the ActivateApprover parameter is not processed correctly
     when an approver does not exist.
     FIXES [#5423](https://github.com/microsoft/Microsoft365DSC/issues/5423)
     FIXES [#5415](https://github.com/microsoft/Microsoft365DSC/issues/5415)
@@ -73,12 +129,17 @@
   * Initial release.
 * SCPolicyConfig
   * Fixed an issue extracting empty groups properties.
+* TeamsMeetingPolicy
+  * FIXES #5442(https://github.com/microsoft/Microsoft365DSC/issues/5442)
 * TeamsUpdateManagementPolicy
   * Added conversion of the UpdateTimeOfDay parameter to the local culture format
     so that the comparison will work consistently.
     FIXES [#5424](https://github.com/microsoft/Microsoft365DSC/issues/5424)
 * M365DSCDRGUtil
   * Improve CIM instance detection for specific Intune resources.
+* AADUser
+  * Fixed issue updating user group membership when looking for the group by DisplayName.
+  * Fixed missing User Id when changing  group membership in Set-TargetResource function.
 
 # 1.24.1113.1
 

diff --git a/...s/Microsoft365DSC/DSCResources/MSFT_AADAccessReviewPolicy/MSFT_AADAccessReviewPolicy.psm1 b/...s/Microsoft365DSC/DSCResources/MSFT_AADAccessReviewPolicy/MSFT_AADAccessReviewPolicy.psm1
@@ -24,6 +24,10 @@ function Get-TargetResource
         [System.String]
         $TenantId,
 
+        [Parameter()]
+        [System.Management.Automation.PSCredential]
+        $ApplicationSecret,
+
         [Parameter()]
         [System.String]
         $CertificateThumbprint,
@@ -67,6 +71,7 @@ function Get-TargetResource
             Credential                    = $Credential
             ApplicationId                 = $ApplicationId
             TenantId                      = $TenantId
+            ApplicationSecret             = $ApplicationSecret
             CertificateThumbprint         = $CertificateThumbprint
             ManagedIdentity               = $ManagedIdentity.IsPresent
             AccessTokens                  = $AccessTokens
@@ -111,6 +116,10 @@ function Set-TargetResource
         [System.String]
         $TenantId,
 
+        [Parameter()]
+        [System.Management.Automation.PSCredential]
+        $ApplicationSecret,
+
         [Parameter()]
         [System.String]
         $CertificateThumbprint,
@@ -171,6 +180,10 @@ function Test-TargetResource
         [System.String]
         $TenantId,
 
+        [Parameter()]
+        [System.Management.Automation.PSCredential]
+        $ApplicationSecret,
+
         [Parameter()]
         [System.String]
         $CertificateThumbprint,
@@ -291,6 +304,7 @@ function Export-TargetResource
                 Credential            = $Credential
                 ApplicationId         = $ApplicationId
                 TenantId              = $TenantId
+                ApplicationSecret     = $ApplicationSecret
                 CertificateThumbprint = $CertificateThumbprint
                 ManagedIdentity       = $ManagedIdentity.IsPresent
                 AccessTokens          = $AccessTokens

diff --git a/...osoft365DSC/DSCResources/MSFT_AADAccessReviewPolicy/MSFT_AADAccessReviewPolicy.schema.mof b/...osoft365DSC/DSCResources/MSFT_AADAccessReviewPolicy/MSFT_AADAccessReviewPolicy.schema.mof
diff --git a/...esources/MSFT_AADCustomAuthenticationExtension/MSFT_AADCustomAuthenticationExtension.psm1 b/...esources/MSFT_AADCustomAuthenticationExtension/MSFT_AADCustomAuthenticationExtension.psm1
@@ -61,6 +61,10 @@ function Get-TargetResource
         [System.String]
         $ApplicationId,
 
+        [Parameter()]
+        [System.Management.Automation.PSCredential]
+        $ApplicationSecret,
+
         [Parameter()]
         [System.String]
         $TenantId,
@@ -273,6 +277,10 @@ function Set-TargetResource
         [System.String]
         $ApplicationId,
 
+        [Parameter()]
+        [System.Management.Automation.PSCredential]
+        $ApplicationSecret,
+
         [Parameter()]
         [System.String]
         $TenantId,
@@ -458,6 +466,10 @@ function Test-TargetResource
         [System.String]
         $TenantId,
 
+        [Parameter()]
+        [System.Management.Automation.PSCredential]
+        $ApplicationSecret,
+
         [Parameter()]
         [System.String]
         $CertificateThumbprint,
@@ -606,6 +618,7 @@ function Export-TargetResource
                 Credential            = $Credential
                 ApplicationId         = $ApplicationId
                 TenantId              = $TenantId
+                ApplicationSecret     = $ApplicationSecret
                 CertificateThumbprint = $CertificateThumbprint
                 ManagedIdentity       = $ManagedIdentity.IsPresent
                 AccessTokens          = $AccessTokens

diff --git a/...es/MSFT_AADCustomAuthenticationExtension/MSFT_AADCustomAuthenticationExtension.schema.mof b/...es/MSFT_AADCustomAuthenticationExtension/MSFT_AADCustomAuthenticationExtension.schema.mof
diff --git a/...les/Microsoft365DSC/DSCResources/MSFT_AADEnrichedAuditLogs/MSFT_AADEnrichedAuditLogs.psm1 b/...les/Microsoft365DSC/DSCResources/MSFT_AADEnrichedAuditLogs/MSFT_AADEnrichedAuditLogs.psm1
@@ -32,6 +32,10 @@ function Get-TargetResource
         [System.String]
         $TenantId,
 
+        [Parameter()]
+        [System.Management.Automation.PSCredential]
+        $ApplicationSecret,
+
         [Parameter()]
         [System.String]
         $CertificateThumbprint,
@@ -72,6 +76,7 @@ function Get-TargetResource
             Credential            = $Credential
             ApplicationId         = $ApplicationId
             TenantId              = $TenantId
+            ApplicationSecret     = $ApplicationSecret
             CertificateThumbprint = $CertificateThumbprint
             ManagedIdentity       = $ManagedIdentity.IsPresent
             AccessTokens          = $AccessTokens
@@ -124,6 +129,10 @@ function Set-TargetResource
         [System.String]
         $TenantId,
 
+        [Parameter()]
+        [System.Management.Automation.PSCredential]
+        $ApplicationSecret,
+
         [Parameter()]
         [System.String]
         $CertificateThumbprint,
@@ -204,6 +213,10 @@ function Test-TargetResource
         [System.String]
         $TenantId,
 
+        [Parameter()]
+        [System.Management.Automation.PSCredential]
+        $ApplicationSecret,
+
         [Parameter()]
         [System.String]
         $CertificateThumbprint,
@@ -311,6 +324,7 @@ function Export-TargetResource
             Credential            = $Credential
             ApplicationId         = $ApplicationId
             TenantId              = $TenantId
+            ApplicationSecret     = $ApplicationSecret
             CertificateThumbprint = $CertificateThumbprint
             ManagedIdentity       = $ManagedIdentity.IsPresent
             AccessTokens          = $AccessTokens

diff --git a/...crosoft365DSC/DSCResources/MSFT_AADEnrichedAuditLogs/MSFT_AADEnrichedAuditLogs.schema.mof b/...crosoft365DSC/DSCResources/MSFT_AADEnrichedAuditLogs/MSFT_AADEnrichedAuditLogs.schema.mof
diff --git a/...t365DSC/DSCResources/MSFT_AADFederationConfiguration/MSFT_AADFederationConfiguration.psm1 b/...t365DSC/DSCResources/MSFT_AADFederationConfiguration/MSFT_AADFederationConfiguration.psm1
@@ -53,6 +53,10 @@ function Get-TargetResource
         [System.String]
         $TenantId,
 
+        [Parameter()]
+        [System.Management.Automation.PSCredential]
+        $ApplicationSecret,
+
         [Parameter()]
         [System.String]
         $CertificateThumbprint,
@@ -127,6 +131,7 @@ function Get-TargetResource
             Credential                      = $Credential
             ApplicationId                   = $ApplicationId
             TenantId                        = $TenantId
+            ApplicationSecret               = $ApplicationSecret
             CertificateThumbprint           = $CertificateThumbprint
             ManagedIdentity                 = $ManagedIdentity.IsPresent
             AccessTokens                    = $AccessTokens
@@ -200,6 +205,10 @@ function Set-TargetResource
         [System.String]
         $TenantId,
 
+        [Parameter()]
+        [System.Management.Automation.PSCredential]
+        $ApplicationSecret,
+
         [Parameter()]
         [System.String]
         $CertificateThumbprint,
@@ -324,6 +333,10 @@ function Test-TargetResource
         [System.String]
         $TenantId,
 
+        [Parameter()]
+        [System.Management.Automation.PSCredential]
+        $ApplicationSecret,
+
         [Parameter()]
         [System.String]
         $CertificateThumbprint,
@@ -446,6 +459,7 @@ function Export-TargetResource
                 Credential            = $Credential
                 ApplicationId         = $ApplicationId
                 TenantId              = $TenantId
+                ApplicationSecret     = $ApplicationSecret
                 CertificateThumbprint = $CertificateThumbprint
                 ManagedIdentity       = $ManagedIdentity.IsPresent
                 AccessTokens          = $AccessTokens

diff --git a/...C/DSCResources/MSFT_AADFederationConfiguration/MSFT_AADFederationConfiguration.schema.mof b/...C/DSCResources/MSFT_AADFederationConfiguration/MSFT_AADFederationConfiguration.schema.mof
diff --git a/Modules/Microsoft365DSC/DSCResources/MSFT_AADFilteringPolicy/MSFT_AADFilteringPolicy.psm1 b/Modules/Microsoft365DSC/DSCResources/MSFT_AADFilteringPolicy/MSFT_AADFilteringPolicy.psm1
@@ -37,6 +37,10 @@ function Get-TargetResource
         [System.String]
         $TenantId,
 
+        [Parameter()]
+        [System.Management.Automation.PSCredential]
+        $ApplicationSecret,
+
         [Parameter()]
         [System.String]
         $CertificateThumbprint,
@@ -109,6 +113,7 @@ function Get-TargetResource
             Credential            = $Credential
             ApplicationId         = $ApplicationId
             TenantId              = $TenantId
+            ApplicationSecret     = $ApplicationSecret
             CertificateThumbprint = $CertificateThumbprint
             ManagedIdentity       = $ManagedIdentity.IsPresent
             AccessTokens          = $AccessTokens
@@ -166,6 +171,10 @@ function Set-TargetResource
         [System.String]
         $TenantId,
 
+        [Parameter()]
+        [System.Management.Automation.PSCredential]
+        $ApplicationSecret,
+
         [Parameter()]
         [System.String]
         $CertificateThumbprint,
@@ -259,6 +268,10 @@ function Test-TargetResource
         [System.String]
         $TenantId,
 
+        [Parameter()]
+        [System.Management.Automation.PSCredential]
+        $ApplicationSecret,
+
         [Parameter()]
         [System.String]
         $CertificateThumbprint,
@@ -380,6 +393,7 @@ function Export-TargetResource
                 Credential            = $Credential
                 ApplicationId         = $ApplicationId
                 TenantId              = $TenantId
+                ApplicationSecret     = $ApplicationSecret
                 CertificateThumbprint = $CertificateThumbprint
                 ManagedIdentity       = $ManagedIdentity.IsPresent
                 AccessTokens          = $AccessTokens

diff --git a/...s/Microsoft365DSC/DSCResources/MSFT_AADFilteringPolicy/MSFT_AADFilteringPolicy.schema.mof b/...s/Microsoft365DSC/DSCResources/MSFT_AADFilteringPolicy/MSFT_AADFilteringPolicy.schema.mof