This repository has been archived by the owner on Jul 19, 2024. It is now read-only.
Add ReferenceCopyLocalPaths to csproj to find implementation dll for … #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adamtuliper This PR looks like it contains more than is mentioned in the description. Was that intentional? |
carmines
reviewed
Jun 11, 2018
| <SpecificVersion>False</SpecificVersion> | ||
| <HintPath>$(SolutionDir)..\..\..\Build\$(Configuration)\Plugins\WSA\$(PlatformName)\MixedRemoteViewCompositor.winmd</HintPath> | ||
| <Reference Include="MixedRemoteViewCompositor"> | ||
| <HintPath>..\..\..\..\Source\Win32\MixedRemoteViewCompositor.winmd</HintPath> |
There was a problem hiding this comment.
modify the path to the repo's build folder "$(SolutionDir)......\Build$(Configuration)\Plugins".
| <TargetPlatformVersion>10.0.10586.0</TargetPlatformVersion> | ||
| <TargetPlatformMinVersion>10.0.10240.0</TargetPlatformMinVersion> | ||
| <TargetPlatformVersion>10.0.16299.0</TargetPlatformVersion> | ||
| <TargetPlatformMinVersion>10.0.16299.0</TargetPlatformMinVersion> |
There was a problem hiding this comment.
HoloLens OS is 14393 RS1 and RS4 only. Check your builds run on both
| @@ -1,2 +1 @@ | |||
| m_EditorVersion: 5.4.0b24-HTP | |||
| m_StandardAssetsVersion: 0 | |||
| m_EditorVersion: 2017.2.0p2 | |||
There was a problem hiding this comment.
ensure the check-in works against 2017.4 LTS build for RS4
| @@ -1,7 +1,7 @@ | |||
| | |||
| Microsoft Visual Studio Solution File, Format Version 12.00 | |||
| # Visual Studio 14 | |||
| VisualStudioVersion = 14.0.25420.1 | |||
| # Visual Studio 15 | |||
There was a problem hiding this comment.
there are additional changes needed for x64, latest SDK and to build correctly without warnings for 2017. See my repo for a version that compiles cleanly:
https://github.com/carmines/MixedRealityCompanionKit/tree/master/MixedRemoteViewCompositor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve the "implementation file not found" issue in #199
Since the MixedRemoteViewCompositor reference is set CopyLocal=true, we can use the to point to the dll.
I believe we can also leave SpecificVersion=false out, since it looks like Visual Studio defaults to SpecificVersion=false if we don't have a version/culture on the reference.