Add a blob value / type and tests #2097
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Public API changes: |
|
Issue #1725. |
MikeStall
reviewed
Jan 30, 2024
|
|
||
| public override string ToString() | ||
| { | ||
| return "o"; |
MikeStall
reviewed
Jan 30, 2024
| var evaluator = _engine.Check("Set(b, BlobCreation(\"myid\"))", opts, _symbolTable).GetEvaluator(); | ||
| var result = await evaluator.EvalAsync(default, _runtimeConfig).ConfigureAwait(false); | ||
|
|
||
| // Set() returns constant 'true; |
MikeStall
reviewed
Jan 30, 2024
| evaluator = _engine.Check("b", opts, _symbolTable).GetEvaluator(); | ||
| result = await evaluator.EvalAsync(default, _runtimeConfig).ConfigureAwait(false); | ||
| var blobValue = result as BlobValue; | ||
| Assert.NotNull(blobValue); |
There was a problem hiding this comment.
super nit: can we just cast? Then we'll get a more meaningful exception?
MikeStall
reviewed
Jan 30, 2024
|
|
||
| namespace Microsoft.PowerFx.Types | ||
| { | ||
| public class BlobValue : PrimitiveValue<string> |
|
Should we extend IValueVisitor to include BlobValue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.