Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves error message when putting value inside record and table. #2255

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jas-valgotar
Copy link
Contributor

Fixes #2196

@jas-valgotar jas-valgotar requested a review from a team as a code owner March 14, 2024 15:31
@jas-valgotar jas-valgotar marked this pull request as draft March 14, 2024 15:52
@LucGenetier
Copy link
Contributor

✅ No public API change.

@jas-valgotar jas-valgotar force-pushed the jas/void-record-error branch 2 times, most recently from 84a846d to 88be203 Compare March 14, 2024 16:17
@LucGenetier
Copy link
Contributor

✅ No public API change.

@jas-valgotar jas-valgotar force-pushed the jas/void-record-error branch 3 times, most recently from f1e5b73 to 738e189 Compare March 14, 2024 18:57
@jas-valgotar jas-valgotar marked this pull request as ready for review March 14, 2024 18:58
@LucGenetier
Copy link
Contributor

✅ No public API change.

@LucGenetier
Copy link
Contributor

✅ No public API change.

@LucGenetier
Copy link
Contributor

✅ No public API change.

@jas-valgotar jas-valgotar enabled auto-merge (squash) March 18, 2024 23:10
@jas-valgotar jas-valgotar requested review from CarlosFigueiraMSFT and removed request for CarlosFigueiraMSFT March 19, 2024 18:40
@CarlosFigueiraMSFT
Copy link
Contributor

CarlosFigueiraMSFT commented Mar 20, 2024

        TestBindingError(script, Features.None, errorMessage, symbolTable);

Not really related to your changes, but we should be using Features.PowerFxV1, as no host uses Features.None. Same in line 90 #Resolved


Refers to: src/tests/Microsoft.PowerFx.Interpreter.Tests/DeferredTypeTests.cs:116 in aba9876. [](commit_id = aba9876, deletion_comment = False)

@jas-valgotar jas-valgotar marked this pull request as draft March 20, 2024 22:49
auto-merge was automatically disabled March 20, 2024 22:49

Pull request was converted to draft

@jas-valgotar jas-valgotar force-pushed the jas/void-record-error branch 2 times, most recently from 656eaf4 to 1d66900 Compare March 20, 2024 23:03
@LucGenetier
Copy link
Contributor

✅ No public API change.

@jas-valgotar
Copy link
Contributor Author

        TestBindingError(script, Features.None, errorMessage, symbolTable);

Updated to V1


In reply to: 2010778690


Refers to: src/tests/Microsoft.PowerFx.Interpreter.Tests/DeferredTypeTests.cs:116 in aba9876. [](commit_id = aba9876, deletion_comment = False)

@LucGenetier
Copy link
Contributor

✅ No public API change.

@jas-valgotar jas-valgotar marked this pull request as ready for review March 21, 2024 18:39
@jas-valgotar jas-valgotar enabled auto-merge (squash) March 21, 2024 22:39
@LucGenetier
Copy link
Contributor

✅ No public API change.

@LucGenetier
Copy link
Contributor

✅ No public API change.

@jas-valgotar jas-valgotar marked this pull request as draft June 10, 2024 14:00
auto-merge was automatically disabled June 10, 2024 14:00

Pull request was converted to draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error message when void values are assigned in record.
4 participants