Removing lexer validation for special chars #2310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ No public API change. |
|
UFB (new formula bar) has a logical dependency on the Lexer for its default syntax hightlighting capabilities and like Lexer (before this pr), UFB disallowed format category. After this pr goes in, UFB would no longer have parity with the Lexer. How frequent are the cases where identifiers contain these format category chars? |
MikeStall
reviewed
Apr 10, 2024
| @@ -1567,7 +1567,7 @@ private Token LexStringLit() | |||
| _sb.Append(ch); | |||
| NextChar(); | |||
| } | |||
| else if (!CharacterUtils.IsFormatCh(ch)) | |||
| else | |||
There was a problem hiding this comment.
To migitate breaks, can we limit this to under v1 flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2309