WIP: Adds warning on comparing same FirstNameNode #2312
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a warning when comparing two identical FirstNameNode instances, which could be either global or scoped variables.
This enhancement is particularly beneficial in scenarios involving scoped variables, where it's easy to misunderstand the concept of implicit
ThisRecord
.It's important to note that this change is non-breaking, as it only adds a warning without generating an error.