Add IsDelegatable and IsPageable flags to UDF class #2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rick-nguyen
force-pushed
the
rnguyen/udf-delegation-pagination
branch
from
826b878
to
64674bd
Compare
…uyen/udf-delegation-pagination
adithyaselv
reviewed
Jun 13, 2024
|
|
||
| public bool IsPageable => _binding?.IsPageable(_binding.Top) ?? false; | ||
|
|
||
| public bool IsDelegatable => _binding?.IsDelegatable(_binding.Top) ?? false; |
There was a problem hiding this comment.
Can you add few binding tests with simple and deeply nested expressions using this mock datasource
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These flags will allow the binder to mark a UDF as delegatable/pageable correctly based on the rule bound to it.