UO field set changes #2533
Closed
UO field set changes #2533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderson-joyle
force-pushed
the
andersonf/2520-uo-coercion
branch
from
6c926a5
to
9317610
Compare
anderson-joyle
added
the
Breaking Internals
anderson-joyle
force-pushed
the
andersonf/2520-uo-coercion
branch
from
9317610
to
0f3b7d7
Compare
MikeStall
reviewed
Jul 9, 2024
src/libraries/Microsoft.PowerFx.Core/Public/Values/UntypedObjectValue.cs
Outdated
Show resolved
Hide resolved
MikeStall
reviewed
Jul 9, 2024
src/libraries/Microsoft.PowerFx.Core/Public/Values/UntypedObjectValue.cs
Outdated
Show resolved
Hide resolved
MikeStall
reviewed
Jul 9, 2024
MikeStall
reviewed
Jul 9, 2024
MikeStall
reviewed
Jul 9, 2024
src/libraries/Microsoft.PowerFx.Interpreter/Functions/ArrayUntypedObject.cs
Outdated
Show resolved
Hide resolved
MikeStall
reviewed
Jul 10, 2024
anderson-joyle
force-pushed
the
andersonf/2520-uo-coercion
branch
from
0f3b7d7
to
68183c0
Compare
even if arg0 is UO, we should still do this check. Set(ParseJson("1"), value) // fail at compile time Refers to: src/libraries/Microsoft.PowerFx.Interpreter/Functions/SetFunction.cs:121 in bf5df32. [](commit_id = bf5df32, deletion_comment = False) |
MikeStall
reviewed
Jul 11, 2024
src/libraries/Microsoft.PowerFx.Core/Public/Values/UntypedObjectValue.cs
Outdated
Show resolved
Hide resolved
MikeStall
reviewed
Jul 11, 2024
src/tests/Microsoft.PowerFx.Interpreter.Tests.Shared/DateTimeUTCTests.cs
Outdated
Show resolved
Hide resolved
anderson-joyle
changed the title
anderson-joyle
removed
the
Breaking Internals
MikeStall
reviewed
Jul 12, 2024
| internal virtual UntypedObjectValue CreateNew(IRContext irContext, IUntypedObject impl) | ||
| { | ||
| return new UntypedObjectValue(irContext, impl); | ||
| } |
There was a problem hiding this comment.
ohhh.... this is not ideal. I'll followup offline...
Should we have called CreateNew() here? More broadly - the issue with CreateNew is that it's at odds with the UntypedObjectValue() ctor. Refers to: src/libraries/Microsoft.PowerFx.Interpreter/Functions/LibraryUntypedObject.cs:458 in c92d9de. [](commit_id = c92d9de, deletion_comment = False) |
MikeStall
reviewed
Jul 15, 2024
| { | ||
| TextLiteralNode textLiteralNode = (TextLiteralNode)bon.Right; | ||
|
|
||
| // !!!TODO What if property name does not exist? |
|
Superceded by #2547 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2501.
Allowing the following scenarios:
Set(Index(uoTable, 1).Id, uoValue)Set(Index(uoTable, 1).Id, 99)