Adding optional range param to custom fx2nl param #2541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeStall
reviewed
Jul 11, 2024
src/libraries/Microsoft.PowerFx.LanguageServerProtocol/Protocol/CustomFx2NLParams.cs
Outdated
Show resolved
Hide resolved
MikeStall
reviewed
Jul 11, 2024
src/libraries/Microsoft.PowerFx.LanguageServerProtocol/Protocol/CustomFx2NLParams.cs
Outdated
Show resolved
Hide resolved
akshar2401
reviewed
Jul 11, 2024
...rosoft.PowerFx.Interpreter.Tests.Shared/LanguageServiceProtocol/LegacyLanguageServerTests.cs
Outdated
Show resolved
Hide resolved
...Interpreter.Tests.Shared/LanguageServiceProtocol/RedesignedLanguageServerTests/Fx2NLTests.cs
Outdated
Show resolved
Hide resolved
akshar2401
reviewed
Jul 11, 2024
src/libraries/Microsoft.PowerFx.LanguageServerProtocol/Protocol/CustomFx2NLParams.cs
Outdated
Show resolved
Hide resolved
akshar2401
reviewed
Jul 12, 2024
src/libraries/Microsoft.PowerFx.LanguageServerProtocol/Protocol/ScalarRange.cs
Outdated
Show resolved
Hide resolved
akshar2401
previously approved these changes
Jul 12, 2024
…rs/nthekkumpat/update-customfx2nlparam
MikeStall
reviewed
Jul 15, 2024
src/libraries/Microsoft.PowerFx.LanguageServerProtocol/Protocol/ScalarRange.cs
Show resolved
Hide resolved
MikeStall
reviewed
Jul 15, 2024
src/libraries/Microsoft.PowerFx.LanguageServerProtocol/Protocol/ScalarRange.cs
Show resolved
Hide resolved
Initially I had a test but removed the changes now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the expected params for Fx2Nl (CustomFx2NLParams) with an optional range field.
This will be used and passed down for the explain this partial formula explanation.