Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom exception for errors from Yaml Validator Library #706

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

abaskk-msft
Copy link
Contributor

@abaskk-msft abaskk-msft commented Jul 26, 2024

  • Added custom exception to handle expected exceptions from YamlValidator. This will be used in PAC CLI to indicate the error came from the YamlValidator library if the schema couldn't be loaded from the assembly when the IValidatorFactory is asked to create a new validator.

  • Also changed the printing format of Validator Results (inconsequential)

Problem

Custom exception to be used by library callers to handle errors

Solution

What are we doing to solve this issue?

Changes

  • Log what was changed
  • Log what was changed
  • Log what was changed

Validation

  • How did you verify that this issue is truly fixed?

@abaskk-msft abaskk-msft requested review from a team as code owners July 26, 2024 23:22
@abaskk-msft abaskk-msft requested a review from mizrael July 29, 2024 16:00
@abaskk-msft abaskk-msft merged commit 5b4aa54 into master Jul 29, 2024
4 checks passed
@abaskk-msft abaskk-msft deleted the users/t-abaskar/yaml-validator-customexception branch July 29, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants