PaYamlV3 schema and OM updates #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove `Groups` from control containers - Add `ControlInstance.Group` name to allow a control to belong to a group for use in Studio - Removed `InstanceCreationParameters` as no longer needed - Add `ControlInstance.Variant` as this will be part of required properties for some 1P controls - Updated v3 yaml schema: - With all updates above - Added top-level `DataSources` property to PaModule files.
swapnilbhalgat
approved these changes
Sep 6, 2024
mesganmsft
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After some discussion with McCall, Marcel, Mesganaw, Chris, we made some changes to the schema that makes breaking changes to:
Solution
Updated PaYamlV3 OM and schema accordingly
Changes
Remove
Groupsfrom control containersAdd
ControlInstance.Groupname to allow a control to belong to a group for use in StudioRemoved
InstanceCreationParametersas no longer neededAdd
ControlInstance.Variantas this will be part of required properties for some 1P controlsUpdated v3 yaml schema:
DataSourcesproperty to PaModule files.Validation