Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[runner]Fix triggering non-set hotkeys #32976

Merged
merged 2 commits into from
May 23, 2024
Merged

[runner]Fix triggering non-set hotkeys #32976

merged 2 commits into from
May 23, 2024

Conversation

stefansjfw
Copy link
Collaborator

Summary of the Pull Request

Apparently, left-clicking Slack systray icon sends None (vkCode = 0) keyboard input. As all of the modifier keys are false (if not pressed) this is the same as key combination as default non-set Hotkey{}. therefore, whatever non-set hotkey was not set - was triggered.

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Without this fix:

  • Copy some text
  • Left click slack systray icon and observe that text is pasted into slack input text box

With the fix:

  • Follow the same steps and observe that nothing is pasted into slack

@stefansjfw stefansjfw changed the title Fix triggering non-set hotkeys [runner]Fix triggering non-set hotkeys May 22, 2024
jaimecbernardo
jaimecbernardo approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@jaimecbernardo jaimecbernardo added the Hot Fix Items we will product an out-of-band release for label May 22, 2024
@stefansjfw
Copy link
Collaborator Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stefansjfw
Copy link
Collaborator Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stefansjfw
Copy link
Collaborator Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jaimecbernardo
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stefansjfw
Copy link
Collaborator Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stefansjfw
Copy link
Collaborator Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stefansjfw
Copy link
Collaborator Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jaimecbernardo jaimecbernardo merged commit 8fce41d into main May 23, 2024
15 checks passed
@jaimecbernardo jaimecbernardo mentioned this pull request May 23, 2024
Closed
11 tasks
@carlos-zamora carlos-zamora mentioned this pull request May 29, 2024
Closed
@crutkas crutkas deleted the stefan/fix_32971 branch June 15, 2024 03:29
@ghost
Copy link

ghost commented Jul 13, 2024

/azp run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaimecbernardo jaimecbernardo jaimecbernardo approved these changes

Assignees
No one assigned
Labels
Hot Fix Items we will product an out-of-band release for
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefansjfw @jaimecbernardo