Instrument convert attrs to properties

[jenshnielsen]

Not completely sure it we want to go this way. Taken from #4273 where its no longer needed

[codecov]

Codecov Report

Merging #4417 (5ba252c) into master (d38994c) will decrease coverage by 0.02%.
The diff coverage is 87.80%.

@@            Coverage Diff             @@
##           master    #4417      +/-   ##
==========================================
- Coverage   68.38%   68.36%   -0.03%     
==========================================
  Files         275      275              
  Lines       31021    31047      +26     
==========================================
+ Hits        21215    21225      +10     
- Misses       9806     9822      +16     

[codecov]

Codecov Report

Attention: Patch coverage is 86.48649% with 5 lines in your changes missing coverage. Please review.

Project coverage is 67.35%. Comparing base (faefd25) to head (1274299).

Files with missing lines	Patch %	Lines
src/qcodes/instrument/instrument_base.py	86.20%	4 Missing ⚠️
src/qcodes/metadatable/metadatable_base.py	87.50%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4417   +/-   ##
=======================================
  Coverage   67.34%   67.35%           
=======================================
  Files         352      352           
  Lines       32143    32169   +26     
=======================================
+ Hits        21647    21667   +20     
- Misses      10496    10502    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.