Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rohde & Schwarz SGS100A Trigger and Pulse Modulator parameters #5889

Merged

Conversation

hp-peti
Copy link
Contributor

@hp-peti hp-peti commented Mar 25, 2024

Additional parameters for the Pulse Modulation module of the R&S SG100A Signal Generator

Based on the manual.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 67.45%. Comparing base (d522c68) to head (982687a).
Report is 4 commits behind head on main.

Files Patch % Lines
...qcodes/instrument_drivers/rohde_schwarz/SGS100A.py 94.11% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5889      +/-   ##
==========================================
+ Coverage   67.44%   67.45%   +0.01%     
==========================================
  Files         348      348              
  Lines       30120    30132      +12     
==========================================
+ Hits        20313    20325      +12     
  Misses       9807     9807              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenshnielsen
Copy link
Collaborator

@hp-peti Could you please add a newsfragment descriping this change and documented in the pull request template text

@hp-peti
Copy link
Contributor Author

hp-peti commented Apr 5, 2024

added missing news fragment. pleas approve 6 workflows
thanks in advance

@jenshnielsen jenshnielsen added this pull request to the merge queue Apr 5, 2024
Merged via the queue into microsoft:main with commit 12f5577 Apr 5, 2024
19 checks passed
@hp-peti hp-peti deleted the hp-peti/rohde-schwarz-module-parameters branch April 5, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants