Netcdf: Only allow invalid netcdf features when required #6566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
force-pushed
the
jenshnielsen/xarray_complex_conditional
branch
from
84ce986
to
2183f37
Compare
jenshnielsen
changed the title
jenshnielsen
force-pushed
the
jenshnielsen/xarray_complex_conditional
branch
from
2183f37
to
0aa54aa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6566 +/- ##
=======================================
Coverage 69.33% 69.34%
=======================================
Files 340 340
Lines 31261 31266 +5
=======================================
+ Hits 21676 21681 +5
Misses 9585 9585 ☔ View full report in Codecov by Sentry. |
picarro-yren
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the newest versions of xarray/h5netcdf it is no longer required to use invalid netcdf features to export complex numbers. We therefor only enable this with older package versions