the python side of the xlang changes #4256
Open
+779
−155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rysweet
commented
Nov 18, 2024
rysweet
commented
- changes to _worker_runtime.py that adds serialization for cloud events
- samples for xlang by Peter
unneeded change
| @@ -0,0 +1,15 @@ | |||
| { | |||
There was a problem hiding this comment.
Don't checkin appsettings.Development.json
| @@ -98,7 +98,7 @@ public static implicit operator AIFunctionMetadata(FunctionContract contract) | |||
| [NamespaceKey] = contract.Namespace, | |||
| [ClassNameKey] = contract.ClassName, | |||
| }, | |||
| Parameters = [.. contract.Parameters?.Select(p => (AIFunctionParameterMetadata)p)], | |||
| Parameters = [.. contract.Parameters?.Select(p => (AIFunctionParameterMetadata)p)!], | |||
There was a problem hiding this comment.
Is this change relevant?
| @@ -8,6 +8,7 @@ public interface IAgentWorker | |||
| ValueTask PublishEventAsync(CloudEvent evt, CancellationToken cancellationToken = default); | |||
| ValueTask SendRequestAsync(IAgentBase agent, RpcRequest request, CancellationToken cancellationToken = default); | |||
There was a problem hiding this comment.
The IAgentRuntime and IAgentWorker looks quite similar, can we combine them?
(Not in this PR, maybe in the future)
ekzhu
reviewed
Nov 19, 2024
| ), | ||
| metadata=get_telemetry_grpc_metadata(), | ||
| ) | ||
| await self._process_event(event) |
There was a problem hiding this comment.
Just leave a note here. We need to wrap RpcRequest, RpcResponse and Event in to CloudEvent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.