Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete autogen-ext refactor deprecations #4305

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lspinheiro
Copy link
Collaborator

Why are these changes needed?

The changes are

  1. Delete openai client from autogen_core
  2. Delete symlinks to code_executor and tools.langchain that where refactored in autogen_ext
  3. Update files that relied on the deprecated imports

Those changes are needed as part of the refactor clean up before 0.4.0 release.

Related issue number

Checks

@lspinheiro lspinheiro marked this pull request as ready for review November 22, 2024 03:31
@@ -65,7 +65,7 @@
"metadata": {},
"outputs": [],
"source": [
"def get_model_client() -> OpenAIChatCompletionClient:\n",
"def get_model_client() -> OpenAIChatCompletionClient: # type: ignore\n",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems mypy has issues with the autogen_ext imports in the docs, in this case it complains about the export type as it cant follow the import. Open to suggestions if this can be fixed rather than ignored.

@lspinheiro lspinheiro changed the title delete files and update dependencies Delete autogen-ext refactor deprecations Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants