Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system msg when calling inside the assistant tool loop (#4308) #4309

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

gziz
Copy link
Contributor

@gziz gziz commented Nov 22, 2024

Why are these changes needed?

The AssistantAgent determines when it needs to use tools. After all necessary tools are used during the tool execution while loop the agent makes one model_client call to generate a response based on the tool results.
The issue is that this model client call doesn't include the system message.

Related issue number

#4308

Checks

Copy link

@yeandy yeandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rysweet
Copy link
Collaborator

rysweet commented Nov 22, 2024

Thanks @gziz

@rysweet rysweet merged commit 232068a into microsoft:main Nov 22, 2024
40 checks passed
@gz1z gz1z deleted the fix_assistant_model_call branch November 22, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants