add tolerance for empty choices #4311
Open
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mohammad Mazraeh <mazraeh.mohammad@gmail.com>
rysweet
reviewed
Nov 22, 2024
| @@ -556,6 +556,7 @@ async def create_stream( | |||
| json_output: Optional[bool] = None, | |||
| extra_create_args: Mapping[str, Any] = {}, | |||
| cancellation_token: Optional[CancellationToken] = None, | |||
| max_empty_consequative_chunk_tolerance: Optional[int] = 0, | |||
There was a problem hiding this comment.
Should be "max_consecutive..."?
| @@ -566,6 +567,7 @@ async def create_stream( | |||
| json_output (Optional[bool], optional): If True, the output will be in JSON format. Defaults to None. | |||
| extra_create_args (Mapping[str, Any], optional): Additional arguments for the creation process. Default to `{}`. | |||
| cancellation_token (Optional[CancellationToken], optional): A token to cancel the operation. Defaults to None. | |||
| max_empty_consequative_chunk_tolerance (int, optional): The maximum number of consecutive empty chunks to tolerate before stopping the stream. Defaults to 3. | |||
There was a problem hiding this comment.
Looks like it defaults to zero?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
I encountered this issue only in
AzureOpenAIChatCompletionClient, adding some tolerance for emptychoices! Not a super clean fix ... just works to unblock updating streaming samples usingAzureOpenAIChatCompletionClientRelated issue number
closes #4213
Checks