-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove resource estimator from azure-quantum-python SDK (26574) #654
Conversation
…-lib-pr.yml to keep the PR-check pipeline from hanging
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
microsoft.azure-quantum-python.ci appears to have hung again... |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
The "/azp run" got errors 500 and 503 from GitHub |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Looks like PR-check microsoft.azure-quantum-python.ci failed to start again. |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, changes all look good to me. Main comment would be if we can completely remove visualization/build/visualization-lib-pr.yml
, but we could do this later if it's causing issues.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
very-nit: we still have a couple of places where we mention Resource Estimator in the comments:
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Removed references to the service-based resource estimator from the azure-quantum-python SDK