Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove resource estimator from azure-quantum-python SDK (26574) #654

Merged
merged 12 commits into from
Jan 15, 2025

Conversation

warren-jones
Copy link
Contributor

@warren-jones warren-jones commented Jan 9, 2025

Removed references to the service-based resource estimator from the azure-quantum-python SDK

@warren-jones warren-jones self-assigned this Jan 9, 2025
@warren-jones
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@warren-jones
Copy link
Contributor Author

warren-jones commented Jan 11, 2025

microsoft.azure-quantum-python.ci appears to have hung again...

@warren-jones
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@warren-jones
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@warren-jones
Copy link
Contributor Author

The "/azp run" got errors 500 and 503 from GitHub
Trying it again...

@warren-jones
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@warren-jones
Copy link
Contributor Author

Looks like PR-check microsoft.azure-quantum-python.ci failed to start again.
Giving it a nudge…

@warren-jones
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@warren-jones
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@warren-jones warren-jones marked this pull request as ready for review January 14, 2025 02:07
@warren-jones warren-jones requested a review from a team as a code owner January 14, 2025 02:07
Copy link

@almullay almullay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, changes all look good to me. Main comment would be if we can completely remove visualization/build/visualization-lib-pr.yml, but we could do this later if it's causing issues.

@warren-jones
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@warren-jones warren-jones requested a review from almullay January 15, 2025 01:05
Copy link

@almullay almullay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@kikomiss
Copy link
Contributor

very-nit: we still have a couple of places where we mention Resource Estimator in the comments:

@kikomiss
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@warren-jones warren-jones merged commit bf08ff7 into main Jan 15, 2025
6 checks passed
@warren-jones warren-jones deleted the v-warrjones/remove-resource-estimator branch January 15, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants