-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Teams] Add support for meeting participants added/removed events #6677
Merged
tracyboehrer
merged 5 commits into
main
from
southworks/add/teams-meeting-participant-events
Aug 16, 2023
Merged
[Teams] Add support for meeting participants added/removed events #6677
tracyboehrer
merged 5 commits into
main
from
southworks/add/teams-meeting-participant-events
Aug 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceciliaavila
added
the
Automation: Parity with js
The PR needs to be ported to JS
label
Jul 31, 2023
Pull Request Test Coverage Report for Build 364374
💛 - Coveralls |
Hi @tracyboehrer, there's a problem with the CI pipeline in this PR. We think is related to the custom Nuget feed. |
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll |
rm3f
approved these changes
Aug 15, 2023
rm3f
approved these changes
Aug 16, 2023
tracyboehrer
approved these changes
Aug 16, 2023
tracyboehrer
deleted the
southworks/add/teams-meeting-participant-events
branch
August 16, 2023 19:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#minor
Description
This PR is based on #5809. It adds support to TeamsActivityHandler for meeting participant join/leave events.
Specific Changes
application/vnd.microsoft.meetingParticipantJoin
andapplication/vnd.microsoft.meetingParticipantLeave
.Testing
These images show the new unit tests passing and the implementation tested with a sample.