Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6643] WithManagedIdentity is experimental and not exist in Microsoft.Identity.Client 4.51.0 #6686

Merged
merged 4 commits into from
Sep 19, 2023

Conversation

sw-joelmut
Copy link
Collaborator

Fixes #6643

Description

This PR updates the Microsoft.Identity.Client package from 4.50 to 4.55 to implement the official MSI functionality.

Specific Changes

  • Replaced IConfidentialClientApplication with IManagedIdentityApplication.
  • Replaced AcquireTokenForClient with AcquireTokenForManagedIdentity due to the new application type.
  • Removed unused _appId property.
  • Removed experimental flag.
  • Removed scopes, only the resource is required.

Testing

The following image shows the bot working with the new implementation.
image

@sw-joelmut sw-joelmut added the Automation: No parity PR does not need to be applied to other languages. label Aug 25, 2023
@sw-joelmut sw-joelmut requested a review from a team as a code owner August 25, 2023 20:07
@sw-joelmut
Copy link
Collaborator Author

Hi @tracyboehrer, there's a problem with the CI pipeline in this PR. We think it is related to the new version of Microsoft.Identity.Client not being available in the custom NuGet feed.
Thanks.

@tracyboehrer
Copy link
Member

@sw-joelmut This PR is failing due to what @Danieladu is working on in #6687. Though that PR isn't currently building. Perhaps some coordination is in order.

@tracyboehrer
Copy link
Member

@sw-joelmut This is failing due to some Microsoft.Bot.Connector.Tests failures.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 369407

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.006%) to 73.448%

Files with Coverage Reduction New Missed Lines %
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/ServiceCollectionExtensions.cs 1 93.55%
/libraries/Microsoft.Bot.Connector.Streaming/Application/TimerAwaitable.cs 1 68.25%
/libraries/Microsoft.Bot.Connector/Authentication/ManagedIdentityAuthenticator.cs 3 86.11%
Totals Coverage Status
Change from base Build 369254: -0.006%
Covered Lines: 24140
Relevant Lines: 32867

💛 - Coveralls

@BruceHaley
Copy link
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll

@tracyboehrer tracyboehrer merged commit c2f3aea into main Sep 19, 2023
13 of 14 checks passed
@tracyboehrer tracyboehrer deleted the southworks/update/msi-implementation branch September 19, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WithManagedIdentity is experimental and not exist in Microsoft.Identity.Client 4.51.0
4 participants