Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#6825] Update xunit and fix compatibility issues in unit tests #6836

Merged
merged 6 commits into from
Aug 12, 2024

Conversation

JhontSouth
Copy link
Collaborator

Addresses #6825
#minor

Description

This PR updates xunit package version from 2.4.1 to 2.9.0 and applies the respective changes to meet the new version requirements.

Specific Changes

  • Changed async void methods to async Task.
  • Swapped assert equal parameters to leave the expected value in the correct argument position.
  • Changed assert equal comparison of size collection 0 and 1 to Empty and Single methods.
  • Added async operators instead of the use of Wait, GetAwaiter, and Result methods.

Testing

The following image shows the unit tests working in Net 6.0 and 8.0.
image

@JhontSouth JhontSouth requested a review from a team as a code owner August 1, 2024 19:41
@JhontSouth JhontSouth added the Automation: No parity PR does not need to be applied to other languages. label Aug 1, 2024
@tracyboehrer
Copy link
Member

@JhontSouth Conflicts

@BruceHaley
Copy link
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Streaming.dll

@tracyboehrer tracyboehrer merged commit 429903a into main Aug 12, 2024
12 checks passed
@tracyboehrer tracyboehrer deleted the southworks/update/xunit branch August 12, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants