Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid SM02211 issue alert #6843

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

JhontSouth
Copy link
Collaborator

#minor

Description

This PR adds a comment to clarify the TypeNameHandling alert thrown in AzureQueueStorage.

Specific Changes

  • Added CodeQL comment to JsonSerializerSettings instantiation in AzureQueueStorage constructors.

Testing

This PR doesn't require a testing proof.

@JhontSouth JhontSouth added the Automation: No parity PR does not need to be applied to other languages. label Aug 20, 2024
@JhontSouth JhontSouth requested a review from a team as a code owner August 20, 2024 13:13
@tracyboehrer tracyboehrer merged commit 5717a10 into main Aug 20, 2024
10 checks passed
@tracyboehrer tracyboehrer deleted the southworks/fix/SM02211-issue branch August 20, 2024 13:55
tracyboehrer added a commit that referenced this pull request Sep 10, 2024
* Fix for Skills endorsement check (#6846)

Co-authored-by: Tracy Boehrer <trboehre@microsoft.com>

* FederatedAppCredentials and factory

* add token credential authentication to BlobsTranscriptStore (#6813)

* [#6741] Remove .Net Core 3.1 from projects (#6819)

* Remove netcoreapp3.1 and fix System.Text.Json issue

* Fix System.Formats.Asn1 security issue

* Fix remaining System.Text.Json issue

* Removed unused argument from FederatedAuthenticator.CreateClientApplication

* Fix Microsoft.Bcl.AsyncInterfaces warning (#6837)

# Conflicts:
#	libraries/Microsoft.Bot.Builder.Azure/Microsoft.Bot.Builder.Azure.csproj

* add code ql comment about TypeNameHandling.None (#6843)

---------

Co-authored-by: Tracy Boehrer <trboehre@microsoft.com>
Co-authored-by: Jhonatan Sandoval Velasco <122501764+JhontSouth@users.noreply.github.com>
Co-authored-by: Joel Mut <62260472+sw-joelmut@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants