Skip to content

Commit

Permalink
graduate pipreport (#1219)
Browse files Browse the repository at this point in the history
  • Loading branch information
pauld-msft authored Aug 6, 2024
1 parent 80146ce commit 3d161b0
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 23 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ namespace Microsoft.ComponentDetection.Detectors.Pip;
using Microsoft.ComponentDetection.Contracts.TypedComponent;
using Microsoft.Extensions.Logging;

public class PipComponentDetector : FileComponentDetector
public class PipComponentDetector : FileComponentDetector, IDefaultOffComponentDetector
{
private readonly IPythonCommandService pythonCommandService;
private readonly IPythonResolver pythonResolver;
Expand All @@ -38,7 +38,7 @@ public PipComponentDetector(

public override IEnumerable<ComponentType> SupportedComponentTypes { get; } = new[] { ComponentType.Pip };

public override int Version { get; } = 12;
public override int Version { get; } = 13;

protected override async Task<IObservable<ProcessRequest>> OnPrepareDetectionAsync(
IObservable<ProcessRequest> processRequests,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ namespace Microsoft.ComponentDetection.Detectors.Pip;
using Microsoft.Extensions.Logging;
using Newtonsoft.Json;

public class PipReportComponentDetector : FileComponentDetector, IExperimentalDetector
public class PipReportComponentDetector : FileComponentDetector
{
// environment variables
private const string PipReportOverrideBehaviorEnvVar = "PipReportOverrideBehavior";
Expand Down Expand Up @@ -76,7 +76,7 @@ private enum PipReportOverrideBehavior

public override IEnumerable<ComponentType> SupportedComponentTypes { get; } = new[] { ComponentType.Pip };

public override int Version { get; } = 5;
public override int Version { get; } = 6;

protected override bool EnableParallelism { get; set; } = true;

Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ public static IServiceCollection AddComponentDetection(this IServiceCollection s
services.AddSingleton<IExperimentConfiguration, SimplePipExperiment>();
services.AddSingleton<IExperimentConfiguration, RustCliDetectorExperiment>();
services.AddSingleton<IExperimentConfiguration, GoDetectorReplaceExperiment>();
services.AddSingleton<IExperimentConfiguration, PipReportExperiment>();

// Detectors
// CocoaPods
Expand Down

0 comments on commit 3d161b0

Please sign in to comment.