Handle duplicate DiffId docker image layers (#64)

microsoft · Feb 9, 2022 · 9605418 · 9605418
1 parent 60e2b6d
commit 9605418
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/Microsoft.ComponentDetection.Detectors/linux/LinuxContainerDetector.cs b/src/Microsoft.ComponentDetection.Detectors/linux/LinuxContainerDetector.cs
@@ -111,6 +111,7 @@ await DockerService.TryPullImageAsync(image, cancellationToken)))
                     }
                     catch (Exception e)
                     {
+                        Logger.LogWarning($"Processing of image {image} failed with exception: {e.Message}");
                         using var record = new LinuxContainerDetectorImageDetectionFailed
                         {
                             ExceptionType = e.GetType().ToString(),
@@ -153,6 +154,7 @@ await DockerService.TryPullImageAsync(image, cancellationToken)))
                 }
                 catch (Exception e)
                 {
+                    Logger.LogWarning($"Scanning of image {kvp.Key} failed with exception: {e.Message}");
                     using var record = new LinuxContainerDetectorImageDetectionFailed
                     {
                         ExceptionType = e.GetType().ToString(),

diff --git a/src/Microsoft.ComponentDetection.Detectors/linux/LinuxScanner.cs b/src/Microsoft.ComponentDetection.Detectors/linux/LinuxScanner.cs
@@ -90,10 +90,12 @@ public async Task<IEnumerable<LayerMappedLinuxComponents>> ScanLinuxAsync(string
                     $"Scan failed with exit info: {stdout}{Environment.NewLine}{stderr}");
             }
 
-            var layerDictionary = dockerLayers.ToDictionary(
-                layer => layer.DiffId,
-                layer => new List<LinuxComponent>());
-
+            var layerDictionary = dockerLayers
+                .DistinctBy(layer => layer.DiffId)
+                .ToDictionary(
+                    layer => layer.DiffId,
+                    _ => new List<LinuxComponent>());
+
             try
             {
                 var syftOutput = JsonConvert.DeserializeObject<SyftOutput>(stdout);