Handle an edge case of root node being null in conan.lock file.

microsoft · Aug 4, 2023 · d0bfe90 · d0bfe90
1 parent 7c947e7
commit d0bfe90
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 2 deletions.
diff --git a/src/Microsoft.ComponentDetection.Detectors/conan/ConanLockComponentDetector.cs b/src/Microsoft.ComponentDetection.Detectors/conan/ConanLockComponentDetector.cs
@@ -54,12 +54,12 @@ protected override async Task OnFileFoundAsync(ProcessRequest processRequest, ID
             if (packagesDictionary.ContainsKey("0"))
             {
                 packagesDictionary.Remove("0", out var rootNode);
-                if (rootNode.Requires != null)
+                if (rootNode?.Requires != null)
                 {
                     explicitReferencedDependencies = new HashSet<string>(rootNode.Requires);
                 }
 
-                if (rootNode.BuildRequires != null)
+                if (rootNode?.BuildRequires != null)
                 {
                     developmentDependencies = new HashSet<string>(rootNode.BuildRequires);
                 }

diff --git a/test/Microsoft.ComponentDetection.Detectors.Tests/ConanLockComponentDetectorTests.cs b/test/Microsoft.ComponentDetection.Detectors.Tests/ConanLockComponentDetectorTests.cs
@@ -94,6 +94,26 @@ public class ConanLockComponentDetectorTests : BaseDetectorTest<ConanLockCompone
  ""profile_host"": ""someLongProfileHostSettingsString\n"",
  ""profile_build"": ""someLongProfileBuildSettingsString\n""
 }
+";
+
+    private readonly string testConanLockStringWithNullValueForRootNode = @"{
+ ""graph_lock"": {
+  ""nodes"": {
+   ""0"": null,
+   ""1"": {
+    ""ref"": ""libabc/1.2.12#someHashOfLibAbc"",
+    ""options"": ""someOptionsString"",
+    ""package_id"": ""packageIdOfLibAbc"",
+    ""prev"": ""someHashOfLibAbc"",
+    ""context"": ""host""
+   }
+  },
+  ""revisions_enabled"": true
+ },
+ ""version"": ""0.4"",
+ ""profile_host"": ""someLongProfileHostSettingsString\n"",
+ ""profile_build"": ""someLongProfileBuildSettingsString\n""
+}
 ";
 
     private readonly string testConanLockNoDependenciesString = @"{
@@ -163,6 +183,20 @@ public async Task TestGraphIsCorrectAsync()
         graph.GetDependenciesForComponent("libanotherlibrary2 3.4.5#someHashOfLibAnotherLibrary2 - Conan").Should().BeEquivalentTo(new[] { "libanotherlibrary3 4.5.6#someHashOfLibAnotherLibrary3 - Conan" });
     }
 
+    [TestMethod]
+    public async Task TestDetectionForConanLockFileWithNullValuesForRootNodeAsync()
+    {
+        var (result, componentRecorder) = await this.DetectorTestUtility
+            .WithFile("Conan.lock", this.testConanLockStringWithNullValueForRootNode)
+            .ExecuteDetectorAsync();
+
+        result.ResultCode.Should().Be(ProcessingResultCode.Success);
+        componentRecorder.GetDetectedComponents().Count().Should().Be(1);
+
+        (componentRecorder.GetDetectedComponents().First().Component as ConanComponent).Name.Should().Be("libabc");
+        (componentRecorder.GetDetectedComponents().First().Component as ConanComponent).Version.Should().Be("1.2.12#someHashOfLibAbc");
+    }
+
     [TestMethod]
     public async Task TestConanDetectorAsync()
     {