Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record NuGet PackageDownloads #1296

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented Oct 31, 2024

Read PackageDownloads from the assets file and record them as top-level development dependencies.

Read PackageDownloads from the assets file and record them as top-level development dependencies.
@ericstj ericstj requested a review from a team as a code owner October 31, 2024 22:56
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.4%. Comparing base (a55475d) to head (828fd3b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...get/NuGetPackageReferenceFrameworkAwareDetector.cs 78.9% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1296     +/-   ##
=======================================
- Coverage   89.1%   88.4%   -0.7%     
=======================================
  Files        378     378             
  Lines      28631   28659     +28     
  Branches    1822    1828      +6     
=======================================
- Hits       25522   25352    -170     
- Misses      2721    2912    +191     
- Partials     388     395      +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericstj
Copy link
Member Author

ericstj commented Nov 11, 2024

@grvillic -- thoughts on this one?

Copy link
Contributor

@grvillic grvillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

@grvillic grvillic enabled auto-merge (squash) November 14, 2024 20:29
@grvillic grvillic merged commit 60c6b90 into microsoft:main Nov 14, 2024
19 of 23 checks passed
Copy link

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants