Add .NETCoreApp 1.1 runtime packages to FrameworkPackages #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericstj
added a commit
to dotnet/runtime
that referenced
this pull request
Nov 5, 2024
I was reviewing correctness of framework package exclusion in component-governance and noticed these 1.x era packages were not being treated correctly. microsoft/component-detection#1298
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1298 +/- ##
=======================================
- Coverage 89.1% 89.1% -0.1%
=======================================
Files 378 378
Lines 28631 28647 +16
Branches 1822 1822
=======================================
+ Hits 25522 25536 +14
Misses 2721 2721
- Partials 388 390 +2 ☔ View full report in Codecov by Sentry. |
|
I think I might have some duplicates I can remove. Will test locally and reduce. |
These runtime packages were all part of .NETCore 1.x. They should have been consistently suppressed from .NETCore 2.0 and later, but were missing from the PackageOverrides.txt list. They were part of the platform manifest though and would be excluded by conflict resolution when doing a metadata comparison.
|
Closing this in favor of #1300 which incorporates these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These packages are referenced when building RID-specific / self-contained applications and referencing 1.x era .NET Core packages.