[WIP] Fix isExplicitReferencedDependency in Poetry Detector #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Magorsch <maxmagorsch@microsoft.com>
Signed-off-by: Max Magorsch <maxmagorsch@microsoft.com>
Signed-off-by: Max Magorsch <maxmagorsch@microsoft.com>
This reverts commit a81b4f8.
arzano
changed the title
arzano
changed the title
cobya
added
type:bug
|
@arzano is this PR still WIP? |
cobya
added
the
status:waiting-on-response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is work in progress currently still and not ready to be merged yet. The goal is to fix the poetry detector.
The problem with the current implementation is that the "isExplicitlyReferencedDependency" is never set by the poetry detector.