Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users/oakeredolu/newpipdetector #684

Merged
merged 26 commits into from
Aug 8, 2023
Merged

Conversation

Omotola
Copy link
Contributor

@Omotola Omotola commented Jul 31, 2023

Added a new experimental pip detector that uses the simple pypi resolver and client. It has been tested locally and it detects the same components as the baseline detector. #672
image

Tested with more components:
image

Diff is 0
image

@Omotola Omotola requested a review from a team as a code owner July 31, 2023 08:45
@Omotola Omotola requested a review from JamieMagee July 31, 2023 08:45
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@Omotola Omotola merged commit 0afc58b into main Aug 8, 2023
21 of 22 checks passed
@Omotola Omotola deleted the users/oakeredolu/newpipdetector branch August 8, 2023 17:05
@melotic melotic added version:minor type:feature Feature (new functionality) labels Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature Feature (new functionality) version:minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants