-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Users/oakeredolu/newpipdetector #684
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into users/oakeredolu/newpipservice
…nt since other arguments are unused
…crosoft/component-detection into users/oakeredolu/newpipservice
…crosoft/component-detection into users/oakeredolu/newpipservice
…icrosoft/component-detection into users/oakeredolu/newpipdetector
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
melotic
reviewed
Aug 2, 2023
src/Microsoft.ComponentDetection.Detectors/pip/SimplePipComponentDetector.cs
Outdated
Show resolved
Hide resolved
melotic
reviewed
Aug 2, 2023
src/Microsoft.ComponentDetection.Detectors/pip/SimplePipComponentDetector.cs
Outdated
Show resolved
Hide resolved
…ore cases, and did some error logging
… into users/oakeredolu/newpipdetector
melotic
reviewed
Aug 3, 2023
src/Microsoft.ComponentDetection.Detectors/pip/SimplePipComponentDetector.cs
Outdated
Show resolved
Hide resolved
melotic
reviewed
Aug 7, 2023
src/Microsoft.ComponentDetection.Detectors/pip/SimplePipComponentDetector.cs
Outdated
Show resolved
Hide resolved
melotic
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new experimental pip detector that uses the simple pypi resolver and client. It has been tested locally and it detects the same components as the baseline detector. #672
Tested with more components:
Diff is 0