-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Users/oakeredolu/pipsharedcache #695
Conversation
return Task.FromResult<HttpResponseMessage>(null); | ||
} | ||
|
||
return this.GetAndCachePyPiResponseAsync(requestUri); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this bypassing the cache?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be adding to cache here instead. fixed it. There's a check to get from cache at the top of this conditional before it gets to this point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually I think I misunderstood your question. do you mean is the shared cache bypassing this internal cache? yes it is, i'm checking the shared cache first and if it returns nothing, then it enters this retry block and tries to get from the internal cache and if that returns nothing, it sends a request to the pypi api.
…ld and new apis are different
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
Shared cache for the old and new pip detectors to help with performance