-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Location of Experiments Call to CD Internal #720
Conversation
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
…://github.com/microsoft/component-detection into users/avannikumar/moveExperimentsCallLocation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks experiments in CD. In CD these are written to disk, and then they are submitted to CG in 1P uses. If we never process experiments in CD, they will never be written to disk.
You need a way to process experiments at different times.
src/Microsoft.ComponentDetection.Orchestrator/Experiments/IExperimentService.cs
Outdated
Show resolved
Hide resolved
…://github.com/microsoft/component-detection into users/avannikumar/moveExperimentsCallLocation
test/Microsoft.ComponentDetection.Orchestrator.Tests/Services/DetectorProcessingServiceTests.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ComponentDetection.Orchestrator/Experiments/ExperimentService.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ComponentDetection.Orchestrator/Experiments/DetectorExperiments.cs
Outdated
Show resolved
Hide resolved
Can you fix the build errors? |
…://github.com/microsoft/component-detection into users/avannikumar/moveExperimentsCallLocation
The call needs to be after snapshots are created.