Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Location of Experiments Call to CD Internal #720

Merged
merged 28 commits into from
Aug 17, 2023

Conversation

amitla1
Copy link
Contributor

@amitla1 amitla1 commented Aug 12, 2023

The call needs to be after snapshots are created.

@amitla1 amitla1 requested a review from a team as a code owner August 12, 2023 00:20
@amitla1 amitla1 requested a review from Omotola August 12, 2023 00:20
@github-actions
Copy link

github-actions bot commented Aug 12, 2023

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Copy link
Member

@melotic melotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks experiments in CD. In CD these are written to disk, and then they are submitted to CG in 1P uses. If we never process experiments in CD, they will never be written to disk.

You need a way to process experiments at different times.

@melotic
Copy link
Member

melotic commented Aug 16, 2023

Can you fix the build errors?

@amitla1 amitla1 merged commit 74fae32 into main Aug 17, 2023
21 checks passed
@amitla1 amitla1 deleted the users/avannikumar/moveExperimentsCallLocation branch August 17, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants