Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump org.json4s:json4s-jackson_2.12 to use 3.5.3 for datax-core and datax-keyvault #1229

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 1, 2024

Bumps org.json4s:json4s-jackson_2.12 from 4.0.5 to 4.0.7.

Commits
  • 9be098a Setting version to 4.0.7
  • 6ca473d Update github actions
  • 1cd05c0 add more spec for JsonParser
  • 6b5a7e9 Avoid ClassCastException for Scala.js
  • 90b227c Update scalafmt-core to 3.7.17 in 4.0
  • d7ba742 Update .scala-steward.conf
  • b483abf Update scalaz-core to 7.3.8 in 4.0
  • 15ad0eb Update sbt to 1.9.7 in 4.0
  • 580d5c6 Update nscplugin, sbt-scala-native, ... to 0.4.16 in 4.0
  • 0ae90fd Update sbt-scalajs, scalajs-compiler, ... to 1.14.0 in 4.0
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [org.json4s:json4s-jackson_2.12](https://github.com/json4s/json4s) from 4.0.5 to 4.0.7.
- [Commits](json4s/json4s@v4.0.5...v4.0.7)

---
updated-dependencies:
- dependency-name: org.json4s:json4s-jackson_2.12
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jan 1, 2024
Copy link
Member

@jozavala-msft jozavala-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validate this change at runtime first

@Ed-Maeng
Copy link
Contributor

Ed-Maeng commented May 7, 2024

Looks like we hit an error with this change. Need to do a refactor here.

User class threw exception: java.lang.NoClassDefFoundError: org/json4s/AsJsonInput$
at datax.authentication.ManagedIdentity$.getAccessToken(ManagedIdentity.scala:25)
at datax.keyvault.SecretClientTokenCredential.getToken(KeyVaultMsiAuthenticatorClient.scala:17)
at com.azure.core.credential.TokenCredential.getTokenSync(TokenCredential.java:110)
at datax.keyvault.SecretClientTokenCredential.getTokenSync(KeyVaultMsiAuthenticatorClient.scala:14)
at com.azure.core.implementation.AccessTokenCache.lambda$new$2(AccessTokenCache.java:63)
at com.azure.core.implementation.AccessTokenCache.lambda$retrieveTokenSync$11(AccessTokenCache.java:228)
at com.azure.core.implementation.AccessTokenCache.getTokenSync(AccessTokenCache.java:91)
at com.azure.core.http.policy.BearerTokenAuthenticationPolicy.setAuthorizationHeaderHelperSync(BearerTokenAuthenticationPolicy.java:204)
at com.azure.core.http.policy.BearerTokenAuthenticationPolicy.setAuthorizationHeaderSync(BearerTokenAuthenticationPolicy.java:191)
at com.azure.security.keyvault.secrets.implementation.KeyVaultCredentialPolicy.authorizeRequestOnChallengeSync(KeyVaultCredentialPolicy.java:314)
at com.azure.core.http.policy.BearerTokenAuthenticationPolicy.processSync(BearerTokenAuthenticationPolicy.java:157)
at com.azure.core.http.HttpPipelineNextSyncPolicy.processSync(HttpPipelineNextSyncPolicy.java:53)
at com.azure.core.http.policy.RetryPolicy.attemptSync(RetryPolicy.java:211)
at com.azure.core.http.policy.RetryPolicy.processSync(RetryPolicy.java:161)
at com.azure.core.http.HttpPipelineNextSyncPolicy.processSync(HttpPipelineNextSyncPolicy.java:53)
at com.azure.core.http.policy.AddHeadersPolicy.processSync(AddHeadersPolicy.java:66)
at com.azure.core.http.HttpPipelineNextSyncPolicy.processSync(HttpPipelineNextSyncPolicy.java:53)
at com.azure.core.http.policy.HttpPipelineSyncPolicy.processSync(HttpPipelineSyncPolicy.java:51)
at com.azure.core.http.policy.UserAgentPolicy.processSync(UserAgentPolicy.java:174)
at com.azure.core.http.HttpPipelineNextSyncPolicy.processSync(HttpPipelineNextSyncPolicy.java:53)
at com.azure.core.http.HttpPipeline.sendSync(HttpPipeline.java:138)
at com.azure.core.implementation.http.rest.SyncRestProxy.send(SyncRestProxy.java:62)
at com.azure.core.implementation.http.rest.SyncRestProxy.invoke(SyncRestProxy.java:83)
at com.azure.core.implementation.http.rest.RestProxyBase.invoke(RestProxyBase.java:125)
at com.azure.core.http.rest.RestProxy.invoke(RestProxy.java:97)
at com.sun.proxy.$Proxy42.getSecretSync(Unknown Source)
at com.azure.security.keyvault.secrets.implementation.SecretClientImpl.getSecretWithResponse(SecretClientImpl.java:1133)
at com.azure.security.keyvault.secrets.SecretClient.lambda$getSecretWithResponse$1(SecretClient.java:360)
at com.azure.security.keyvault.secrets.SecretClient.callWithMappedException(SecretClient.java:1025)
at com.azure.security.keyvault.secrets.SecretClient.getSecretWithResponse(SecretClient.java:359)
at com.azure.security.keyvault.secrets.SecretClient.getSecret(SecretClient.java:296)
at datax.securedsetting.KeyVaultClient$.resolveSecret(KeyVaultClient.scala:51)
at datax.securedsetting.KeyVaultClient$.getSecretOrThrow(KeyVaultClient.scala:78)
at datax.securedsetting.KeyVaultClient$.getSecret(KeyVaultClient.scala:92)
at datax.telemetry.AppInsightLogger$.<init>(AppInsightLogger.scala:30)
at datax.telemetry.AppInsightLogger$.<clinit>(AppInsightLogger.scala)
at datax.host.CommonAppHost$.initApp(CommonAppHost.scala:36)
at datax.host.BlobBatchingHost$.runBatchApp(BlobBatchingHost.scala:70)
at datax.app.BatchApp$.main(BatchApp.scala:14)
at datax.app.BatchApp.main(BatchApp.scala)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.apache.spark.deploy.yarn.ApplicationMaster$$anon$2.run(ApplicationMaster.scala:732)
Caused by: java.lang.ClassNotFoundException: org.json4s.AsJsonInput$
at java.lang.ClassLoader.findClass(ClassLoader.java:523)
at org.apache.spark.util.ParentClassLoader.findClass(ParentClassLoader.java:35)
at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
at org.apache.spark.util.ParentClassLoader.loadClass(ParentClassLoader.java:40)
at org.apache.spark.util.ChildFirstURLClassLoader.loadClass(ChildFirstURLClassLoader.java:48)
at java.lang.ClassLoader.loadClass(ClassLoader.java:351)

…into dependabot/maven/DataProcessing/datax-keyvault/org.json4s-json4s-jackson_2.12-4.0.7
@Ed-Maeng Ed-Maeng changed the title Bump org.json4s:json4s-jackson_2.12 from 4.0.5 to 4.0.7 in /DataProcessing/datax-keyvault Bump org.json4s:json4s-jackson_2.12 from 4.0.5 to 4.1.0-M5 in /DataProcessing/datax-keyvault May 10, 2024
@Ed-Maeng Ed-Maeng self-requested a review May 10, 2024 19:28
Copy link
Member

@jozavala-msft jozavala-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please validate the change before merging.

@Ed-Maeng Ed-Maeng changed the title Bump org.json4s:json4s-jackson_2.12 from 4.0.5 to 4.1.0-M5 in /DataProcessing/datax-keyvault Bump org.json4s:json4s-jackson_2.12 to use 3.5.3 for datax-core and datax-keyvault May 11, 2024
@Ed-Maeng
Copy link
Contributor

After validating we need to keep org.json4s:json4s-jackson_2.12 3.5.3 for both datax-core and datax-keyvault.

@Ed-Maeng Ed-Maeng merged commit d7ca8b1 into master May 11, 2024
2 checks passed
@Ed-Maeng Ed-Maeng deleted the dependabot/maven/DataProcessing/datax-keyvault/org.json4s-json4s-jackson_2.12-4.0.7 branch May 11, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants