Migrate MSI Server to MSAL #1460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohit489
reviewed
Aug 30, 2024
|
|
||
| echo "Start the service" | ||
| sudo systemctl start msiserverapp.service |
There was a problem hiding this comment.
Why are we starting msiserverapp.service if we are migrating off of it ?
There was a problem hiding this comment.
I was planning to keep the old server in a different port for now, just in case we might need to revert the changes. Planning to delete the old server and remove it from the script once we have validated everything works fine in prod.
There was a problem hiding this comment.
did you confirm if both msal and adal can run together ?
There was a problem hiding this comment.
Yes! As long as they have a different port and separate service file to run. Dev VS01 cluster is currently running both servers.
rohit489
approved these changes
Aug 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
AcquireTokenForClientcan rely on MSAL's internal caching: https://learn.microsoft.com/en-us/entra/msal/dotnet/acquiring-tokens/acquire-token-silentlyRelated PR