Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump json4s-jackson_2.12 from 3.5.3 to 4.0.6 in /DataProcessing/datax-core #613

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 3, 2022

Bumps json4s-jackson_2.11 from 3.5.3 to 4.0.6.

Commits
  • 26fa34d Setting version to 4.0.6
  • 9c444f3 Fix #553 by using Java's HashSet (#1116)
  • c04989a Update sbt-mima-plugin to 1.1.1 in 4.0
  • 7a2ebec Update scala-library to 2.12.17 in 4.0
  • d4e62a6 Update sbt-scalajs, scalajs-compiler, ... to 1.11.0 in 4.0
  • 8d19ed8 Update nscplugin, sbt-scala-native, ... to 0.4.7 in 4.0
  • 1867784 Update scalafmt-core to 3.5.9 in 4.0
  • 4adcab9 Update scalatest-wordspec to 3.2.13 in 4.0
  • af42059 Update sbt to 1.7.1 in 4.0
  • 73286cc Update sbt to 1.7.0 in 4.0
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [json4s-jackson_2.11](https://github.com/json4s/json4s) from 3.5.3 to 4.0.6.
- [Release notes](https://github.com/json4s/json4s/releases)
- [Commits](json4s/json4s@v3.5.3...v4.0.6)

---
updated-dependencies:
- dependency-name: org.json4s:json4s-jackson_2.11
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Oct 3, 2022
Copy link
Member

@jozavala-msft jozavala-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was another similar PR proposing an upgrade to 4.0.5 that caused a runtime error #270
Taking a look on this one if the same issue persists

@jozavala-msft
Copy link
Member

Local testing job run succeded with the recent version upgrades on dependent artifacts, we should see the runtime error anymore

@jozavala-msft jozavala-msft changed the title Bump json4s-jackson_2.11 from 3.5.3 to 4.0.6 in /DataProcessing/datax-core Bump json4s-jackson_2.12 from 3.5.3 to 4.0.6 in /DataProcessing/datax-core Dec 20, 2023
@jozavala-msft
Copy link
Member

Validate this change at runtime first

Copy link
Member

@jozavala-msft jozavala-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validate this change at runtime first

Ed-Maeng and others added 3 commits April 30, 2024 10:46
…son4s-jackson_2.11-4.0.6' of https://github.com/microsoft/data-accelerator into dependabot/maven/DataProcessing/datax-core/org.json4s-json4s-jackson_2.11-4.0.6
@Ed-Maeng
Copy link
Contributor

Ed-Maeng commented May 7, 2024

Looks like we hit an error with this change. Need to do a refactor here.

User class threw exception: java.lang.NoClassDefFoundError: org/json4s/AsJsonInput$
at datax.authentication.ManagedIdentity$.getAccessToken(ManagedIdentity.scala:25)
at datax.keyvault.SecretClientTokenCredential.getToken(KeyVaultMsiAuthenticatorClient.scala:17)
at com.azure.core.credential.TokenCredential.getTokenSync(TokenCredential.java:110)
at datax.keyvault.SecretClientTokenCredential.getTokenSync(KeyVaultMsiAuthenticatorClient.scala:14)
at com.azure.core.implementation.AccessTokenCache.lambda$new$2(AccessTokenCache.java:63)
at com.azure.core.implementation.AccessTokenCache.lambda$retrieveTokenSync$11(AccessTokenCache.java:228)
at com.azure.core.implementation.AccessTokenCache.getTokenSync(AccessTokenCache.java:91)
at com.azure.core.http.policy.BearerTokenAuthenticationPolicy.setAuthorizationHeaderHelperSync(BearerTokenAuthenticationPolicy.java:204)
at com.azure.core.http.policy.BearerTokenAuthenticationPolicy.setAuthorizationHeaderSync(BearerTokenAuthenticationPolicy.java:191)
at com.azure.security.keyvault.secrets.implementation.KeyVaultCredentialPolicy.authorizeRequestOnChallengeSync(KeyVaultCredentialPolicy.java:314)
at com.azure.core.http.policy.BearerTokenAuthenticationPolicy.processSync(BearerTokenAuthenticationPolicy.java:157)
at com.azure.core.http.HttpPipelineNextSyncPolicy.processSync(HttpPipelineNextSyncPolicy.java:53)
at com.azure.core.http.policy.RetryPolicy.attemptSync(RetryPolicy.java:211)
at com.azure.core.http.policy.RetryPolicy.processSync(RetryPolicy.java:161)
at com.azure.core.http.HttpPipelineNextSyncPolicy.processSync(HttpPipelineNextSyncPolicy.java:53)
at com.azure.core.http.policy.AddHeadersPolicy.processSync(AddHeadersPolicy.java:66)
at com.azure.core.http.HttpPipelineNextSyncPolicy.processSync(HttpPipelineNextSyncPolicy.java:53)
at com.azure.core.http.policy.HttpPipelineSyncPolicy.processSync(HttpPipelineSyncPolicy.java:51)
at com.azure.core.http.policy.UserAgentPolicy.processSync(UserAgentPolicy.java:174)
at com.azure.core.http.HttpPipelineNextSyncPolicy.processSync(HttpPipelineNextSyncPolicy.java:53)
at com.azure.core.http.HttpPipeline.sendSync(HttpPipeline.java:138)
at com.azure.core.implementation.http.rest.SyncRestProxy.send(SyncRestProxy.java:62)
at com.azure.core.implementation.http.rest.SyncRestProxy.invoke(SyncRestProxy.java:83)
at com.azure.core.implementation.http.rest.RestProxyBase.invoke(RestProxyBase.java:125)
at com.azure.core.http.rest.RestProxy.invoke(RestProxy.java:97)
at com.sun.proxy.$Proxy42.getSecretSync(Unknown Source)
at com.azure.security.keyvault.secrets.implementation.SecretClientImpl.getSecretWithResponse(SecretClientImpl.java:1133)
at com.azure.security.keyvault.secrets.SecretClient.lambda$getSecretWithResponse$1(SecretClient.java:360)
at com.azure.security.keyvault.secrets.SecretClient.callWithMappedException(SecretClient.java:1025)
at com.azure.security.keyvault.secrets.SecretClient.getSecretWithResponse(SecretClient.java:359)
at com.azure.security.keyvault.secrets.SecretClient.getSecret(SecretClient.java:296)
at datax.securedsetting.KeyVaultClient$.resolveSecret(KeyVaultClient.scala:51)
at datax.securedsetting.KeyVaultClient$.getSecretOrThrow(KeyVaultClient.scala:78)
at datax.securedsetting.KeyVaultClient$.getSecret(KeyVaultClient.scala:92)
at datax.telemetry.AppInsightLogger$.<init>(AppInsightLogger.scala:30)
at datax.telemetry.AppInsightLogger$.<clinit>(AppInsightLogger.scala)
at datax.host.CommonAppHost$.initApp(CommonAppHost.scala:36)
at datax.host.BlobBatchingHost$.runBatchApp(BlobBatchingHost.scala:70)
at datax.app.BatchApp$.main(BatchApp.scala:14)
at datax.app.BatchApp.main(BatchApp.scala)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.apache.spark.deploy.yarn.ApplicationMaster$$anon$2.run(ApplicationMaster.scala:732)
Caused by: java.lang.ClassNotFoundException: org.json4s.AsJsonInput$
at java.lang.ClassLoader.findClass(ClassLoader.java:523)
at org.apache.spark.util.ParentClassLoader.findClass(ParentClassLoader.java:35)
at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
at org.apache.spark.util.ParentClassLoader.loadClass(ParentClassLoader.java:40)
at org.apache.spark.util.ChildFirstURLClassLoader.loadClass(ChildFirstURLClassLoader.java:48)
at java.lang.ClassLoader.loadClass(ClassLoader.java:351)

@Ed-Maeng
Copy link
Contributor

We already have merged: #1298 which has higher version.

@Ed-Maeng Ed-Maeng closed this May 10, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github May 10, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/maven/DataProcessing/datax-core/org.json4s-json4s-jackson_2.11-4.0.6 branch May 10, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants