Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Enhancement: remove unnecessary echoes #1480

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

anandbonde
Copy link
Contributor

These unnecessary echo statements are causing duplicate output, which may cause confusion around how many times builds commands may be executed.

These unnecessary echo statements are causing duplicate output, which
may cause confusion around how many times builds commands may be
executed.
@anandbonde anandbonde requested a review from iyzhang December 16, 2024 19:09
@anandbonde anandbonde self-assigned this Dec 16, 2024
Copy link

libos = catpowder
commit id = dfedee3

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::inetstack::poll;inetstack::layer4_endpoint::poll_once 19636352.30 666.65 272.40 85.25
bgc::inetstack::poll 9818176.15 1565.57 639.62 58.71
bgc::inetstack::tcp::established::background 11066.73 1751.31 705.51 0.17
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 11066.73 501.42 206.27 23.33
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 11056.29 416.41 169.43 28.78
bgc::inetstack::tcp::established::background;tcp::established::background::sender 11013.82 958.55 371.99 23.13
ioc::network::libos::pop 9030.84 427.20 173.84 0.03
ioc::network::libos::push;inetstack::push 8762.80 6314.09 2613.55 2.18
demikernel::sgafree 8746.06 124.63 50.97 0.01
ioc::network::libos::push 8073.74 34205721.42 13082387.65 37.85
demikernel::push 8073.74 616.01 252.37 0.05
demikernel::sgaalloc 6498.79 151.80 62.22 0.02
demikernel::pop 6035.00 758.53 309.41 0.03
bgc::inetstack::poll;inetstack::poll_bg_work::for::for 5287.34 2380.59 940.44 0.65
ioc::network::libos::pushto 635.00 4671.37 2069.47 2.68
ioc::network::libos::pushto;inetstack::push 635.00 4213.57 1866.90 90.21
demikernel::pushto 635.00 516.20 228.49 0.29
bgc::inetstack::poll;inetstack::poll_bg_work::for::for;udp::receive 199.33 206.48 84.71 59.53
ioc::network::libos::close 47.03 6411.03 2629.54 0.08
ioc::network::libos::connect 41.86 44042.92 18189.92 0.54
bgc::inetstack::tcp::passiveopen::background 41.86 33896.33 13996.93 0.01
ioc::network::libos::accept 38.75 2083.20 849.41 0.00
demikernel::async_close 32.50 880.52 340.73 0.01
demikernel::accept 21.86 1312.71 532.91 0.00
demikernel::connect 20.93 4280.54 1717.26 0.02
demikernel::socket 10.30 1711.16 693.91 0.00
bgc::inetstack::arp::background 6.68 2090.15 848.48 0.00
bgc::inetstack::icmp::background 1.03 3314.07 1356.26 0.00
demikernel::new 1.00 92750362.00 37771385.05 16.55
demikernel::bind 1.00 26920.44 10729.46 0.00
demikernel::listen 1.00 3132.07 1250.45 0.00
demikernel::close 0.00 nan nan 0.00

Copy link

libos = catnip
commit id = dfedee3

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::inetstack::poll;inetstack::layer4_endpoint::poll_once 28005687.40 350.53 140.57 75.88
bgc::inetstack::poll;inetstack::layer4_endpoint::poll_once;catnip::runtime::receive 28005687.40 200.65 80.43 57.28
bgc::inetstack::poll 14002843.70 927.42 372.36 35.58
bgc::inetstack::tcp::established::background 11300.71 1124.24 452.25 0.10
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 11300.71 318.00 128.90 25.63
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 11288.96 342.47 138.60 31.41
bgc::inetstack::tcp::established::background;tcp::established::background::sender 11246.68 303.80 117.65 14.68
ioc::network::libos::pop 9172.27 383.14 153.67 0.02
demikernel::sgafree 8778.45 94.47 38.17 0.01
ioc::network::libos::push;inetstack::push 8762.80 2106.86 869.58 0.66
ioc::network::libos::push;inetstack::push;catnip::runtime::transmit 8762.80 339.20 140.57 15.51
ioc::network::libos::push 8073.74 33508786.87 14791758.03 26.84
demikernel::push 8073.74 718.01 298.08 0.03
demikernel::sgaalloc 6533.92 134.38 55.76 0.01
demikernel::pop 6051.67 535.89 214.64 0.02
bgc::inetstack::poll;inetstack::poll_bg_work::for::for 4661.92 2067.46 816.03 1.36
ioc::network::libos::pushto 1207.33 1367.31 556.08 0.06
ioc::network::libos::pushto;inetstack::push 1207.33 746.12 304.43 54.74
demikernel::pushto 1207.33 486.35 198.48 0.02
ioc::network::libos::pushto;inetstack::push;catnip::runtime::transmit 1207.33 278.03 113.28 37.22
bgc::inetstack::poll;inetstack::poll_bg_work::for::for;udp::receive 540.33 244.53 98.42 68.14
bgc::inetstack::poll;inetstack::poll_bg_work::for::for;catnip::runtime::transmit 259.00 695.55 280.86 3.74
ioc::network::libos::close 49.48 5932.06 2391.44 0.01
bgc::inetstack::tcp::passiveopen::background 41.86 34982.45 14130.04 0.00
ioc::network::libos::connect 41.86 32830.84 13518.48 0.03
ioc::network::libos::connect;catnip::runtime::transmit 41.86 6354.89 2539.11 20.44
ioc::network::libos::accept 37.82 2192.59 882.24 0.00
demikernel::async_close 32.50 682.57 260.14 0.00
demikernel::accept 21.86 1583.63 640.07 0.00
bgc::inetstack::tcp::passiveopen::background;catnip::runtime::transmit 20.93 18750.46 7601.65 19.01
demikernel::connect 20.93 2735.95 1101.47 0.00
bgc::inetstack::tcp::established::background;tcp::established::background::sender;catnip::runtime::transmit 20.93 606.31 243.40 11.54
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger;catnip::runtime::transmit 19.57 1063.87 456.69 5.44
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter;catnip::runtime::transmit 12.12 898.16 393.88 0.09
demikernel::socket 10.30 2429.28 980.54 0.00
bgc::inetstack::arp::background 6.53 2267.13 905.20 0.00
bgc::inetstack::icmp::background 1.05 3044.13 1220.35 0.00
demikernel::new 1.00 1757019061.55 704074765.09 47.24
demikernel::bind 1.00 10000.62 3987.34 0.00
demikernel::listen 1.00 3544.64 1398.76 0.00
demikernel::close 0.00 nan nan 0.00

Copy link
Contributor

@iyzhang iyzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this

Copy link

libos = catnap
commit id = dfedee3

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::catnap::transport::epoll 13269592.51 1993.04 840.54 32.55
demikernel::sgafree 11536.78 73.73 30.76 0.05
demikernel::sgaalloc 11284.42 139.76 59.49 0.12
ioc::network::libos::push;catnap::linux::transport::push 9066.12 691.04 284.60 4.31
ioc::network::libos::push 8800.49 16636.33 6905.25 6.39
demikernel::push 8800.49 561.57 233.19 0.15
ioc::network::libos::pop;catnap::linux::transport::pop 8024.46 397.89 164.73 1.61
ioc::network::libos::pop 7815.97 15835946.78 6561493.18 25.07
demikernel::pop 7815.97 553.26 230.25 0.11
ioc::network::libos::pushto 634.67 7663.10 3017.77 23.88
demikernel::pushto 634.67 473.94 186.50 1.55
ioc::network::libos::pushto;catnap::linux::transport::push 634.67 460.02 180.87 6.02
demikernel::async_close 32.50 881.43 383.52 0.01
ioc::network::libos::connect 24.95 7095047.37 2998937.49 28.13
ioc::network::libos::connect;catnap::linux::transport::connect 24.95 77145.99 33010.59 2.56
demikernel::connect 24.95 2142.94 914.38 0.01
ioc::network::libos::close 18.35 24365.86 10107.03 0.06
ioc::network::libos::close;catnap::linux::transport::close 18.35 23124.54 9592.70 94.91
demikernel::accept 15.42 1430.51 585.50 0.00
ioc::network::libos::accept 15.41 899382009.15 367447603.67 44.99
ioc::network::libos::accept;catnap::linux::transport::accept 15.39 10007.07 4102.84 0.00
demikernel::socket 9.50 158917.01 65975.79 0.29
demikernel::socket;catnap::linux::transport::socket 9.50 156544.29 64996.33 96.46
demikernel::new 1.00 260716.63 108873.42 0.09
demikernel::bind 1.00 28570.48 11724.79 0.01
demikernel::bind;catnap::linux::transport::bind 1.00 23886.78 9799.72 83.43
demikernel::listen 1.00 15500.55 6374.54 0.00
demikernel::listen;catnap::linux::transport::listen 1.00 14266.89 5866.34 92.02
demikernel::close 0.00 nan nan 0.00

@anandbonde anandbonde merged commit 47256e8 into dev Dec 17, 2024
14 checks passed
@anandbonde anandbonde deleted the ab-build-remove-echoes branch December 17, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants