Refining Repository Management's UI. #3557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s/en-us/Resources.resw Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com>
This reverts commit 711dd78.
…microsoft/devhome into user/dhoehna/RepoManagementPage
dhoehna
requested review from
manodasanW,
xhan65,
jsidewhite,
guimafelipe,
huzaifa-d,
vineeththomasalex,
dkbennett,
jaholme,
krschau,
EricJohnson327,
sshilov7,
hart-wilson,
lauren-ciha,
zadesai,
SohamDas2021,
AmelBawa-msft,
ssparach and
a team
krschau
reviewed
Aug 7, 2024
tools/SetupFlow/DevHome.SetupFlow/Extensions/ServiceExtensions.cs
Outdated
Show resolved
Hide resolved
tools/RepositoryManagement/DevHome.RepositoryManagement/DevHome.RepositoryManagement.csproj
Outdated
Show resolved
Hide resolved
...yManagement/DevHome.RepositoryManagement/ViewModels/RepositoryManagementMainPageViewModel.cs
Show resolved
Hide resolved
|
After significant push back This PR will be closed and the branch user/dhoehna/RepoManagement will be the feature branch. |
dhoehna
changed the base branch from
main
to
user/dhoehna/RepositoryManagementDatabase
dhoehna
changed the base branch from
user/dhoehna/RepositoryManagementDatabase
to
user/dhoehna/RepositoryManagementFeature
krschau
reviewed
Aug 7, 2024
tools/RepositoryManagement/DevHome.RepositoryManagement/DevHome.RepositoryManagement.csproj
Outdated
Show resolved
Hide resolved
tools/RepositoryManagement/DevHome.RepositoryManagement/Extensions/ServiceExtensions.cs
Outdated
Show resolved
Hide resolved
...epositoryManagement/DevHome.RepositoryManagement/Views/RepositoryManagementMainPageView.xaml
Outdated
Show resolved
Hide resolved
dhoehna
changed the title
…e.RepositoryManagement.csproj Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com>
…ions/ServiceExtensions.cs Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com>
vineeththomasalex
approved these changes
Aug 7, 2024
DefaultRyan
reviewed
Aug 8, 2024
| <Generator>MSBuild:Compile</Generator> | ||
| </Page> | ||
| </ItemGroup> | ||
| </Project> |
There was a problem hiding this comment.
Does this icon mean the file is missing a newline at the end?
krschau
approved these changes
Aug 8, 2024
DefaultRyan
approved these changes
Aug 8, 2024
dhoehna
merged commit fc754c1
into
user/dhoehna/RepositoryManagementFeature
1 of 4 checks passed
dhoehna
added a commit
that referenced
this pull request
Sep 3, 2024
#3709) * Refining Repository Management's UI. (#3557) * Adding the Repository tool * WIP * View is set up. Test ata as well. * Aligning columns. Adding column spacing. * Reverting this change * Update tools/RepositoryManagement/DevHome.RepositoryManagement/Strings/en-us/Resources.resw Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com> * Adressing comments * Revert "Reverting this change" This reverts commit 711dd78. * Moving to experimental * Disabling by default * Removing from experimental. Addressing comments. * Reverting to main * Update tools/RepositoryManagement/DevHome.RepositoryManagement/DevHome.RepositoryManagement.csproj Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com> * Update tools/RepositoryManagement/DevHome.RepositoryManagement/Extensions/ServiceExtensions.cs Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com> * Removing duplicate xaml code * Adding to the mermaid diagram * Got lost in the shuffle * Removing a refrence --------- Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com> * Adding EF core, database project, and some usage. (#3674) * WIP * EF works. Can save data. * Can read and write. :) * Repos are added when cloned. * Putting save/load into a different class * Adding default values * Cleaning up names and using statements * More comments * Removing refrence to the public nuget * Restoring the nuget config * Adding a test. Better defining dates * Adding some tests * More comments. * Better path comparison. * Removing unused equals code * Adding more comments. Making new migrations * Moving this to experimental * Some comments and fixes * Changing to Windows.SDK and re-adding projects --------- Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com>
dhoehna
added a commit
that referenced
this pull request
Sep 19, 2024
* Refining Repository Management's UI. (#3557) * Adding the Repository tool * WIP * View is set up. Test ata as well. * Aligning columns. Adding column spacing. * Reverting this change * Update tools/RepositoryManagement/DevHome.RepositoryManagement/Strings/en-us/Resources.resw Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com> * Adressing comments * Revert "Reverting this change" This reverts commit 711dd78. * Moving to experimental * Disabling by default * Removing from experimental. Addressing comments. * Reverting to main * Update tools/RepositoryManagement/DevHome.RepositoryManagement/DevHome.RepositoryManagement.csproj Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com> * Update tools/RepositoryManagement/DevHome.RepositoryManagement/Extensions/ServiceExtensions.cs Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com> * Removing duplicate xaml code * Adding to the mermaid diagram * Got lost in the shuffle * Removing a refrence --------- Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com> * Adding EF core, database project, and some usage. (#3674) * WIP * EF works. Can save data. * Can read and write. :) * Repos are added when cloned. * Putting save/load into a different class * Adding default values * Cleaning up names and using statements * More comments * Removing refrence to the public nuget * Restoring the nuget config * Adding a test. Better defining dates * Adding some tests * More comments. * Better path comparison. * Removing unused equals code * Adding more comments. Making new migrations * Moving this to experimental * WIP * Some telemetry and logging * THings build again. * Returning this back * I believe I am understanding this. * Can update * Almost done with open in FE * Try/Catching everything. Open in FE should be done. * Open in CMD works. :) * Re-adding changes lost due to merge * Getting saving straightened out. * WIP * Move Repository done. * Removing 1:1. Finishing RemoveFromList * Adding _items * Adding configuration file information to the repository table * Opening the configuration file location in FE * Deleting a repository. * Add to winget configuration file. * Cleaning up the code * Icon for a configuration file. UI updates when hiding a repo * All the buttons do something. * Removing 'local' * Making sure the test works * New test works * Another TODO * Fixing more things before PR. * Removing another un-used using. * MOre un used usings. * Another Todo * Anotehr TODO * Changing a comment * Update database/DevHome.Database/DatabaseModels/RepositoryManagement/Repository.cs Co-authored-by: Branden Bonaby <105318831+bbonaby@users.noreply.github.com> * Comments * Don't just merge code and expect things to work. * What is in a name? * Adressing comments * Updated the database migration. --------- Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com> Co-authored-by: Branden Bonaby <105318831+bbonaby@users.noreply.github.com>
dhoehna
added a commit
that referenced
this pull request
Oct 2, 2024
* Refining Repository Management's UI. (#3557) * Adding the Repository tool * WIP * View is set up. Test ata as well. * Aligning columns. Adding column spacing. * Reverting this change * Update tools/RepositoryManagement/DevHome.RepositoryManagement/Strings/en-us/Resources.resw Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com> * Adressing comments * Revert "Reverting this change" This reverts commit 711dd78. * Moving to experimental * Disabling by default * Removing from experimental. Addressing comments. * Reverting to main * Update tools/RepositoryManagement/DevHome.RepositoryManagement/DevHome.RepositoryManagement.csproj Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com> * Update tools/RepositoryManagement/DevHome.RepositoryManagement/Extensions/ServiceExtensions.cs Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com> * Removing duplicate xaml code * Adding to the mermaid diagram * Got lost in the shuffle * Removing a refrence --------- Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com> * Adding EF core, database project, and some usage. (#3674) * WIP * EF works. Can save data. * Can read and write. :) * Repos are added when cloned. * Putting save/load into a different class * Adding default values * Cleaning up names and using statements * More comments * Removing refrence to the public nuget * Restoring the nuget config * Adding a test. Better defining dates * Adding some tests * More comments. * Better path comparison. * Removing unused equals code * Adding more comments. Making new migrations * Moving this to experimental * WIP * Some telemetry and logging * THings build again. * Returning this back * I believe I am understanding this. * Can update * Almost done with open in FE * Try/Catching everything. Open in FE should be done. * Open in CMD works. :) * Re-adding changes lost due to merge * Getting saving straightened out. * WIP * Move Repository done. * Removing 1:1. Finishing RemoveFromList * Adding _items * Adding configuration file information to the repository table * Opening the configuration file location in FE * Deleting a repository. * Add to winget configuration file. * Cleaning up the code * Icon for a configuration file. UI updates when hiding a repo * All the buttons do something. * Removing 'local' * Making sure the test works * New test works * Another TODO * Fixing more things before PR. * Removing another un-used using. * MOre un used usings. * Another Todo * Anotehr TODO * Localized strings * WIP * Adding enhanced information if it can be found. * Commit, Filtering, and Sorting. * Fixing up the merge * Removing Move/Delete because of a bug in FileExplorerGitIntegration. * Adding a TODO * A small commit * Removing some unused usings * Update tools/RepositoryManagement/DevHome.RepositoryManagement/Strings/en-us/Resources.resw Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com> * Update tools/RepositoryManagement/DevHome.RepositoryManagement/Strings/en-us/Resources.resw Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com> * Update tools/RepositoryManagement/DevHome.RepositoryManagement/Strings/en-us/Resources.resw Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com> * Adressing comments * Adressing comments * Addressing code quality comments * Update database/DevHome.Database/DatabaseModels/RepositoryManagement/Repository.cs Co-authored-by: Ryan Shepherd <ryansh@microsoft.com> * Fixing some issues. * Added a TODO * Adding drop down to select a source control provider * Hide source control selection * FIxing indentation --------- Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com> Co-authored-by: Ryan Shepherd <ryansh@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
My original plan was to use a feature branch and push all my changes to that. But I already messed it up (on my computer. I spent a good while un-doing my mistake).
Going forward Repository Management is in experimental, visible only on dev builds, and incremental changes will go to main.
References and relevant issues
Detailed description of the pull request / Additional comments
In this PR I did modify a few files
Additionally, I reverted the commit that changed LandingPage.xaml. The version in this PR matches the version in Main.
Validation steps performed
PR checklist