Fix configuration of local WER dumps #3733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timkur
requested review from
xhan65,
aeloros,
jaholme,
andreww-msft,
dabhattimsft and
zadesai
zadesai
approved these changes
Aug 29, 2024
aeloros
approved these changes
Sep 4, 2024
jaholme
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
We weren't specifying the # of cabs we wanted to collect for local crash dump capture. This would typically be ok if global local crash capture was enabled, but since it wasn't, we were inheriting the global "# of cabs to collect", which is 0.
This explicitly sets it to the number of local Watson cabs we'll collect to 10.
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist