SAM - Normalization and ChipWindow #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaspadilha
added a commit
that referenced
this pull request
Jul 31, 2024
rafaspadilha
force-pushed
the
rpadilha/sam_fix
branch
from
af08a98 to
96c57f4
Compare
rafaspadilha
added a commit
that referenced
this pull request
Jul 31, 2024
rafaspadilha
force-pushed
the
rpadilha/sam_fix
branch
from
96c57f4 to
c04169a
Compare
rafaspadilha
added a commit
that referenced
this pull request
Aug 1, 2024
rafaspadilha
force-pushed
the
rpadilha/sam_fix
branch
from
c04169a to
eb48968
Compare
rafaspadilha
force-pushed
the
rpadilha/sam_fix
branch
from
eb48968 to
b00799d
Compare
robertomest
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the
ChipWindownamed tuple with a tuple type alias. This fixes some serialization/deserialization errors that caused the workflow to break.Additionally, this PR modifies how we scale and offset the raster values during normalization before SAM image encoder. After applying the raster's scale and offset normalization on the RGB bands, we now clip the values to the range [0,1] before multiplying them by 255. The lack of clipping operation was leading to inconsistencies in the segmentation masks outputs.