Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.9] Bump go-winio to support go1.22 #2150

Closed
wants to merge 3 commits into from

Conversation

cpuguy83
Copy link

@cpuguy83 cpuguy83 commented May 20, 2024

This brings in a fix from go-winio to fix alignment issues on go1.22.

@cpuguy83 cpuguy83 requested a review from a team as a code owner May 20, 2024 17:51
@cpuguy83 cpuguy83 changed the title Bump go-winio to support go1.22 [0.9] Bump go-winio to support go1.22 May 20, 2024
@cpuguy83 cpuguy83 force-pushed the 0.9_bump_winio_go122 branch 2 times, most recently from bb87d60 to 22e3882 Compare May 20, 2024 18:00
cpuguy83 added 2 commits May 20, 2024 19:04
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
This brings in a fix from go-winio to fix alignment issues on go1.22

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
@cpuguy83 cpuguy83 force-pushed the 0.9_bump_winio_go122 branch from 241c5bd to 5bb7f5f Compare May 20, 2024 19:04
@cpuguy83
Copy link
Author

Talking with @kiashok, it looks like we may want to backport the go-winio fixes instead of bringing in this big update.
@kiashok Is looking into this.

@kiashok
Copy link
Contributor

kiashok commented May 21, 2024

@cpuguy83 I think this should work for getting concerned gowinio fix into hcsshim/release/0.9 microsoft/go-winio#318

@cpuguy83
Copy link
Author

Replaced by #2151

@cpuguy83 cpuguy83 closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants