Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow nullable structs + test. #439

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Allow nullable structs + test. #439

merged 1 commit into from
Feb 1, 2022

Conversation

Strabox
Copy link

@Strabox Strabox commented Jan 27, 2022

Type of PR

  • Documentation changes
  • Code changes
  • Test changes
  • CI-CD changes
  • GitHub Template changes

Purpose of PR

Solve the problem of not being able to write nullable structs (e.g. typically present in complex Avro Schemas).

Observability + Testing

  • What changes or considerations did you make in relation to observability?

Nothing.

  • Did you add testing to account for any new or changed work?

Yes a unit test was added to validate the correction of the change.

Review notes

Issues Closed or Referenced

@Strabox Strabox requested a review from a team as a code owner January 27, 2022 16:46
@ghost
Copy link

ghost commented Jan 27, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@ryancrawcour ryancrawcour merged commit 1fbff28 into microsoft:dev Feb 1, 2022
@ryancrawcour
Copy link
Contributor

@kushagraThapar could you please merge to main and push out a release for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryancrawcour ryancrawcour ryancrawcour approved these changes

@kushagraThapar kushagraThapar kushagraThapar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Strabox @ryancrawcour @kushagraThapar